refactor: use unnamed variables

finally supported by palantir-java-format

Author: ObserverOfTime

pom.xml

@@ -174,7 +174,7 @@
         <configuration>
           <java>
             <palantirJavaFormat>
-              <version>2.73.0</version>
+              <version>2.74.0</version>
               <style>PALANTIR</style>
               <formatJavadoc>false</formatJavadoc>
             </palantirJavaFormat>

src/main/java/io/github/treesitter/jtreesitter/Parser.java

@@ -96,9 +96,8 @@ public Parser setLogger(@Nullable Logger logger) {
         } else {
             var segment = TSLogger.allocate(arena);
             TSLogger.payload(segment, MemorySegment.NULL);
-            // NOTE: can't use _ because of palantir/palantir-java-format#934
             var log = TSLogger.log.allocate(
-                    (p, type, message) -> {
+                    (_, type, message) -> {
                         var logType = Logger.Type.values()[type];
                         logger.accept(logType, message.getString(0));
                     },
@@ -305,9 +304,8 @@ public Optional<Tree> parse(
         var input = TSInput.allocate(arena);
         TSInput.payload(input, MemorySegment.NULL);
         TSInput.encoding(input, encoding.ordinal());
-        // NOTE: can't use _ because of palantir/palantir-java-format#934
         var read = TSInput.read.allocate(
-                (payload, index, point, bytes) -> {
+                (_, index, point, bytes) -> {
                     var result = parseCallback.apply(index, Point.from(point));
                     if (result == null) {
                         bytes.set(C_INT, 0, 0);
@@ -437,8 +435,7 @@ public long get() {
         /** Set the value of the flag. */
         @SuppressWarnings("unused")
         public void set(long value) {
-            // NOTE: can't use _ because of palantir/palantir-java-format#934
-            segment.set(C_LONG_LONG, 0L, this.value.updateAndGet(o -> value));
+            segment.set(C_LONG_LONG, 0L, this.value.updateAndGet(_ -> value));
         }
     }
 }

src/main/java/io/github/treesitter/jtreesitter/internal/ChainedLibraryLookup.java

@@ -16,8 +16,7 @@ private ChainedLibraryLookup() {}
     @Override
     public SymbolLookup get(Arena arena) {
         var serviceLoader = ServiceLoader.load(NativeLibraryLookup.class);
-        // NOTE: can't use _ because of palantir/palantir-java-format#934
-        SymbolLookup lookup = (name) -> Optional.empty();
+        SymbolLookup lookup = (_) -> Optional.empty();
         for (var libraryLookup : serviceLoader) {
             lookup = lookup.or(libraryLookup.get(arena));
         }

src/test/java/io/github/treesitter/jtreesitter/ParserTest.java

@@ -106,8 +106,7 @@ void parseLogger() {
     @DisplayName("parse(callback)")
     void parseCallback() {
         var source = "class Foo {}";
-        // NOTE: can't use _ because of palantir/palantir-java-format#934
-        ParseCallback callback = (offset, p) -> source.substring(offset, Integer.min(offset, source.length()));
+        ParseCallback callback = (offset, _) -> source.substring(offset, Integer.min(offset, source.length()));
         parser.setLanguage(language);
         try (var tree = parser.parse(callback, InputEncoding.UTF_8).orElseThrow()) {
             assertNull(tree.getText());
@@ -120,8 +119,7 @@ void parseCallback() {
     @SuppressWarnings("deprecation")
     void parseTimeout() {
         var source = "}".repeat(1024);
-        // NOTE: can't use _ because of palantir/palantir-java-format#934
-        ParseCallback callback = (offset, p) -> source.substring(offset, Integer.min(source.length(), offset + 1));
+        ParseCallback callback = (offset, _) -> source.substring(offset, Integer.min(source.length(), offset + 1));
 
         parser.setLanguage(language).setTimeoutMicros(2L);
         assertTrue(parser.parse(callback, InputEncoding.UTF_8).isEmpty());
@@ -132,8 +130,7 @@ void parseTimeout() {
     @SuppressWarnings("deprecation")
     void parseCancellation() {
         var source = "}".repeat(1024 * 1024);
-        // NOTE: can't use _ because of palantir/palantir-java-format#934
-        ParseCallback callback = (offset, p) -> source.substring(offset, Integer.min(source.length(), offset + 1));
+        ParseCallback callback = (offset, _) -> source.substring(offset, Integer.min(source.length(), offset + 1));
 
         var flag = new Parser.CancellationFlag();
         parser.setLanguage(language).setCancellationFlag(flag);
@@ -158,8 +155,7 @@ void parseCancellation() {
     @DisplayName("parse(options)")
     void parseOptions() {
         var source = "}".repeat(1024);
-        // NOTE: can't use _ because of palantir/palantir-java-format#934
-        ParseCallback callback = (offset, p) -> source.substring(offset, Integer.min(source.length(), offset + 1));
+        ParseCallback callback = (offset, _) -> source.substring(offset, Integer.min(source.length(), offset + 1));
         var options = new Parser.Options((state) -> state.getCurrentByteOffset() >= 1000);
 
         parser.setLanguage(language);
@@ -169,8 +165,7 @@ void parseOptions() {
     @Test
     void reset() {
         var source = "class foo bar() {}";
-        // NOTE: can't use _ because of palantir/palantir-java-format#934
-        ParseCallback callback = (offset, p) -> source.substring(offset, Integer.min(source.length(), offset + 1));
+        ParseCallback callback = (offset, _) -> source.substring(offset, Integer.min(source.length(), offset + 1));
         var options = new Parser.Options(Parser.State::hasError);
 
         parser.setLanguage(language);

src/test/java/io/github/treesitter/jtreesitter/QueryCursorTest.java

@@ -107,12 +107,12 @@ void findMatches() {
         try (var tree = parser.parse("int y = x + 1;").orElseThrow()) {
             var source =
                     """
-            ((variable_declarator
-              (identifier) @y
-              (binary_expression
-                (identifier) @x))
-              (#not-eq? @y @x))
-            """
+                    ((variable_declarator
+                      (identifier) @y
+                      (binary_expression
+                        (identifier) @x))
+                      (#not-eq? @y @x))
+                    """
                             .stripIndent();
             assertCursor(source, cursor -> {
                 var matches = cursor.findMatches(tree.getRootNode()).toList();
@@ -178,17 +178,20 @@ void findMatches() {
 
         // Verify that `eq?` predicate works with quantified captures
         try (var tree = parser.parse("/* 1 */ /* 1 */ /* 1 */").orElseThrow()) {
-            var source = """
-                (program
-                  . (block_comment) @b (block_comment)+ @a
-                  (#eq? @a @b)
-                )
-                """;
+            var source =
+                    """
+                    (program
+                      .
+                      (block_comment) @b
+                      (block_comment)+ @a
+                      (#eq? @a @b))
+                    """;
             assertCursor(source, cursor -> {
                 var matches = cursor.findMatches(tree.getRootNode()).toList();
                 assertEquals(1, matches.size());
                 assertEquals(
-                    "/* 1 */", matches.getFirst().captures().getFirst().node().getText());
+                        "/* 1 */",
+                        matches.getFirst().captures().getFirst().node().getText());
             });
         }
     }

src/test/java/io/github/treesitter/jtreesitter/QueryTest.java

@@ -36,8 +36,7 @@ static void afterAll() {
 
     @SuppressWarnings("unused")
     private static void assertError(Class<? extends QueryError> type, String source, String message) {
-        // NOTE: can't use _ because of palantir/palantir-java-format#934
-        try (var q = new Query(language, source)) {
+        try (var _ = new Query(language, source)) {
             fail("Expected QueryError to be thrown, but nothing was thrown.");
         } catch (QueryError ex) {
             assertInstanceOf(type, ex);