Fix nullAllowed of Domain for identical operator in UtcConstraintExtractor

Author: hqbhoho

lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/filter/UtcConstraintExtractor.java

@@ -248,7 +248,7 @@ private static Optional<Domain> createDomain(FunctionName functionName, Type typ
             return Optional.of(Domain.create(ValueSet.ofRanges(Range.greaterThanOrEqual(type, startOfDate)), false));
         }
         if (functionName.equals(IDENTICAL_OPERATOR_FUNCTION_NAME)) {
-            return Optional.of(Domain.create(ValueSet.ofRanges(Range.range(type, startOfDate, true, startOfNextDate, false)), true));
+            return Optional.of(Domain.create(ValueSet.ofRanges(Range.range(type, startOfDate, true, startOfNextDate, false)), false));
         }
 
         return Optional.empty();
@@ -363,7 +363,7 @@ private static Optional<Domain> unwrapDateTruncInComparison(String unit, Functio
             if (!constantAtPeriodStart) {
                 return Optional.of(Domain.none(type));
             }
-            return Optional.of(Domain.create(ValueSet.ofRanges(Range.range(type, start, true, end, false)), true));
+            return Optional.of(Domain.create(ValueSet.ofRanges(Range.range(type, start, true, end, false)), false));
         }
         if (functionName.equals(LESS_THAN_OPERATOR_FUNCTION_NAME)) {
             if (constantAtPeriodStart) {

lib/trino-plugin-toolkit/src/test/java/io/trino/plugin/base/filter/TestUtcConstraintExtractor.java

@@ -146,7 +146,7 @@ public void testExtractTimestampTzMillisDateComparison()
                         Map.of(timestampTzColumnSymbol, columnHandle))))
                 .isEqualTo(TupleDomain.withColumnDomains(Map.of(
                         columnHandle,
-                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfDateUtc, true, startOfNextDateUtc, false)), true))));
+                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfDateUtc, true, startOfNextDateUtc, false)), false))));
     }
 
     /**
@@ -216,7 +216,7 @@ public void testExtractTimestampTzMicrosDateComparison()
                         Map.of(timestampTzColumnSymbol, columnHandle))))
                 .isEqualTo(TupleDomain.withColumnDomains(Map.of(
                         columnHandle,
-                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfDateUtc, true, startOfNextDateUtc, false)), true))));
+                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfDateUtc, true, startOfNextDateUtc, false)), false))));
     }
 
     /**
@@ -302,7 +302,7 @@ public void testExtractDateTruncTimestampTzMillisComparison()
                         Map.of(timestampTzColumnSymbol, columnHandle))))
                 .isEqualTo(TupleDomain.withColumnDomains(Map.of(
                         columnHandle,
-                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfDateUtc, true, startOfNextDateUtc, false)), true))));
+                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfDateUtc, true, startOfNextDateUtc, false)), false))));
     }
 
     /**
@@ -388,7 +388,7 @@ public void testExtractDateTruncTimestampTzMicrosComparison()
                         Map.of(timestampTzColumnSymbol, columnHandle))))
                 .isEqualTo(TupleDomain.withColumnDomains(Map.of(
                         columnHandle,
-                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfDateUtc, true, startOfNextDateUtc, false)), true))));
+                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfDateUtc, true, startOfNextDateUtc, false)), false))));
     }
 
     /**
@@ -461,7 +461,7 @@ public void testExtractYearTimestampTzMicrosComparison()
                         Map.of(timestampTzColumnSymbol, columnHandle))))
                 .isEqualTo(TupleDomain.withColumnDomains(Map.of(
                         columnHandle,
-                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfYearUtc, true, startOfNextDateUtc, false)), true))));
+                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfYearUtc, true, startOfNextDateUtc, false)), false))));
     }
 
     /**
@@ -534,7 +534,7 @@ public void testExtractYearTimestampTzMillisComparison()
                         Map.of(timestampTzColumnSymbol, columnHandle))))
                 .isEqualTo(TupleDomain.withColumnDomains(Map.of(
                         columnHandle,
-                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfYearUtc, true, startOfNextDateUtc, false)), true))));
+                        Domain.create(ValueSet.ofRanges(Range.range(columnType, startOfYearUtc, true, startOfNextDateUtc, false)), false))));
     }
 
     @Test