Merge branch 'develop' into mjp/make_outline_hands_outline_independent_of_normal_scale

Author: MaxPalmer-UH

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,38 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Desktop (please complete the following information):**
+ - OS: [e.g. iOS]
+ - Browser [e.g. chrome, safari]
+ - Version [e.g. 22]
+
+**Smartphone (please complete the following information):**
+ - Device: [e.g. iPhone6]
+ - OS: [e.g. iOS8.1]
+ - Browser [e.g. stock browser, safari]
+ - Version [e.g. 22]
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/custom.md

@@ -0,0 +1,10 @@
+---
+name: Custom issue template
+about: Describe this issue template's purpose here.
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

Packages/Tracking/CHANGELOG.md

@@ -11,13 +11,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Added
 - Experimental Meta compatibility mode for the OpenXR provider
 - Added support to upgrade the plugin's Built In Render Pipeline materials (and as a result the example scenes) to the Universal Render Pipeline. This can be set to automatically prompt when the materials don't match the current render pipeline. It does not support downgrading.
+- Changed LeapC PInvoke signatures to support iOS
 
 ### Changed
 - Removed warning suggesting use of both input systems for OpenXR + Ultraleap compatibility now the new input system is fully supported
 - Updated all custom shaders to support the Universal Render Pipeline concurrently with the Built-in Render Pipeline
 - Updated Copyright year to 2025
 - Split tracking preview examples into different groups - common assets, main examples and examples that need the old input manager to work (e.g. UI input)
 - (Service Provider) Expose service IP and port as user settable variables
+- Functions for InterpolateFrame / InterpolateFrameFromTime / GetInterpolatedFrameSize will no longer call LeapC unless a valid device is passed/set
+- LeapServiceProvider Update will no longer request an interpolated frame without a valid device being set
+- LeapServiceProvider FixedUpdate will no longer request an interpolated frame without a valid device and connection, bringing it into line with Update
 
 ### Fixed
 - Fixed some warnings around runtime variables that were only used in editor mode
@@ -29,6 +33,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Clients were not able to subscribe to the events on the PinchDetector and GrabDetector scripts as the properties were exposed as readonly. 
 - GrabDetector detection logic was inverted, so open hands were interpreted as grabs. Now fixed.
 - Fixed issue with scale of outline in GenericHandShader if hand model normals are not a normalized length 
+- Fixed issue with attachment hands red/green/blue materials meta file IDs clashing with the IDs of the files in the original examples, since being moved
 
 ### Known Issues
 - Pose detection scene does not illuminate all poses in green if built for mobile headsets when using URP (2022.3), spotlights don't work as intended on Unity 6.

Packages/Tracking/Core/Runtime/Materials/Built In Render Pipeline (Dynamically Upgradable)/Attachment Hands Example Blue.mat.meta

@@ -140,6 +140,9 @@ public event EventHandler<ConnectionEventArgs> LeapConnection
 
         private bool _disposed = false;
 
+        private bool _loggedNullDeviceWarningForGetInterpolatedFrame = false;
+        private bool _loggedNullDeviceWarningForGetInterpolatedFrameSize = false;
+
         public void Dispose()
         {
             Dispose(true);
@@ -428,7 +431,6 @@ private void handleTrackingMessage(ref LEAP_TRACKING_EVENT trackingMsg, UInt32 d
             }
         }
 
-
         public UInt64 GetInterpolatedFrameSize(Int64 time, Device device = null)
         {
             UInt64 size = 0;
@@ -440,15 +442,18 @@ public UInt64 GetInterpolatedFrameSize(Int64 time, Device device = null)
             }
             else
             {
-                result = LeapC.GetFrameSize(_leapConnection, time, out size);
+                if (!_loggedNullDeviceWarningForGetInterpolatedFrameSize)
+                {
+                    UnityEngine.Debug.LogWarning($"Device is null, requesting the frame size without a valid device (handle) is no longer supported and should be considered obsolete");
+                    _loggedNullDeviceWarningForGetInterpolatedFrameSize = true;
+                }
+                result = eLeapRS.eLeapRS_Unsupported;
             }
 
             reportAbnormalResults("LeapC get interpolated frame call was ", result);
             return size;
         }
 
-
-
         public void GetInterpolatedFrame(Frame toFill, Int64 time, Device device = null)
         {
             UInt64 size = GetInterpolatedFrameSize(time, device);
@@ -461,7 +466,12 @@ public void GetInterpolatedFrame(Frame toFill, Int64 time, Device device = null)
             }
             else
             {
-                result = LeapC.InterpolateFrame(_leapConnection, time, trackingBuffer, size);
+                if (!_loggedNullDeviceWarningForGetInterpolatedFrame)
+                {
+                    UnityEngine.Debug.LogWarning($"Device is null, requesting an interpolated frame without a valid device (handle) is no longer supported and should be considered obsolete");
+                    _loggedNullDeviceWarningForGetInterpolatedFrame= true;
+                }
+                result = eLeapRS.eLeapRS_Unsupported;
             }
 
             reportAbnormalResults("LeapC get interpolated frame call was ", result);
@@ -482,12 +492,17 @@ public void GetInterpolatedFrameFromTime(Frame toFill, Int64 time, Int64 sourceT
 
             if (device != null)
             {
-
                 result = LeapC.InterpolateFrameFromTimeEx(_leapConnection, device.Handle, time, sourceTime, trackingBuffer, size);
             }
             else
             {
-                result = LeapC.InterpolateFrameFromTime(_leapConnection, time, sourceTime, trackingBuffer, size);
+                if (!_loggedNullDeviceWarningForGetInterpolatedFrame)
+                {
+                    UnityEngine.Debug.LogWarning($"Device is null, requesting an interpolated frame (from time) without a valid device (handle) is no longer supported and should be considered obsolete");
+                    _loggedNullDeviceWarningForGetInterpolatedFrame = true; 
+                }
+
+                result = eLeapRS.eLeapRS_Unsupported;
             }
 
             reportAbnormalResults("LeapC get interpolated frame from time call was ", result);