Update file(s) "Packages/unity-utils/." from "unity-korea-community/unity-utils"

Author: KorStrix

Runtime/Extension/CollectionExtension.cs

@@ -39,7 +39,9 @@ public static HashSet<T> ToHashSet<T>(this IEnumerable<T> target)
         public static IEnumerable<T> Foreach<T>(this IEnumerable<T> target, System.Action<T> OnEach)
         {
             foreach (var item in target)
+            {
                 OnEach(item);
+            }
 
             return target;
         }

Runtime/SimplePool.cs

@@ -14,13 +14,25 @@ public class SimplePool<T>
         protected T _originItem { get; private set; }
         protected Func<T, T> _OnCreateInstance;
 
+        public SimplePool(T originItem)
+        {
+            _OnCreateInstance = (origin) => Activator.CreateInstance<T>();
+            Init(originItem, 0);
+        }
+
         public SimplePool(T originItem, int initializeSize = 0)
         {
             _OnCreateInstance = (origin) => Activator.CreateInstance<T>();
             Init(originItem, initializeSize);
         }
 
-        public SimplePool(Func<T> onCreateInstance, int initializeSize = 0)
+        public SimplePool(Func<T> onCreateInstance)
+        {
+            _OnCreateInstance = (origin) => onCreateInstance();
+            Init(onCreateInstance(), 0);
+        }
+
+        public SimplePool(Func<T> onCreateInstance, int initializeSize)
         {
             _OnCreateInstance = (origin) => onCreateInstance();
             Init(onCreateInstance(), initializeSize);

Runtime/SingletonComponentBase.cs

@@ -22,8 +22,8 @@ public static T instance
             }
         }
 
-        private static T s_instance;
-        protected static bool s_isQuitApp { get; private set; } = false;
+        private static T s_instance { get; set; }
+        private static bool s_isQuitApp { get; set; }
 
         void Awake()
         {

Runtime/StateMachineGeneric.cs

@@ -27,7 +27,7 @@ public enum CommandType
         }
 
         [System.Serializable]
-        public struct Command
+        public struct Command : System.IEquatable<Command>
         {
             public CommandType commandType { get; private set; }
             public STATE_ID stateID { get; private set; }
@@ -43,6 +43,16 @@ public Command(CommandType commandType, STATE_ID stateID)
                 this.commandType = commandType;
                 this.stateID = stateID;
             }
+
+            public bool Equals(Command other)
+            {
+                if (commandType.Equals(other.commandType) == false)
+                {
+                    return false;
+                }
+
+                return stateID.Equals(other.stateID);
+            }
         }
 
         public event System.Action<STATE_ID, TSTATE> OnChangeState;

Runtime/Unsubscriber.cs

@@ -10,7 +10,14 @@ public class Unsubscriber<T> : IDisposable
         private IObserver<T> _observer;
         private Action<Unsubscriber<T>> _onDisplose;
 
-        public void Reset(HashSet<IObserver<T>> observers, IObserver<T> observer, Action<Unsubscriber<T>> onDisplose = null)
+        public void Reset(HashSet<IObserver<T>> observers, IObserver<T> observer)
+        {
+            this._observers = observers;
+            this._observer = observer;
+            this._onDisplose = null;
+        }
+
+        public void Reset(HashSet<IObserver<T>> observers, IObserver<T> observer, Action<Unsubscriber<T>> onDisplose)
         {
             this._observers = observers;
             this._observer = observer;

Tests/Runtime/CollectionExtensionTests.cs

@@ -8,10 +8,10 @@ public class CollectionExtensionTests
     [Test]
     public void ToStringCollectionExample()
     {
-        string list = new List<int>() { 1, 2, 3, 4, 5 }.ToStringCollection();
+        string list = new List<int> { 1, 2, 3, 4, 5 }.ToStringCollection();
         Debug.Log(list);
 
-        string dictionary = new Dictionary<string, int>()
+        string dictionary = new Dictionary<string, int>
         {
             {"one", 1}, {"two", 2}, {"three", 3},
         }.ToStringCollection();
@@ -21,14 +21,14 @@ public void ToStringCollectionExample()
     [Test]
     public void ForeachExample()
     {
-        int[] originArray = new int[] { 1, 2, 3, 4, 5 };
+        int[] originArray = new[] { 1, 2, 3, 4, 5 };
         originArray.Foreach(number => Debug.Log(number));
     }
 
     [Test]
     public void DequeueExample()
     {
-        List<int> list = new List<int>() { 1, 2, 3 };
+        List<int> list = new List<int> { 1, 2, 3 };
         Assert.AreEqual(list.Dequeue(), 1);
         Assert.AreEqual(list.Count, 2);
 
@@ -42,7 +42,7 @@ public void DequeueExample()
     [Test]
     public void PopExample()
     {
-        List<int> list = new List<int>() { 1, 2, 3 };
+        List<int> list = new List<int> { 1, 2, 3 };
         Assert.AreEqual(list.Pop(), 3);
         Assert.AreEqual(list.Count, 2);
 

Tests/Runtime/DataSenderTests.cs

@@ -5,7 +5,7 @@
 
 public class DataSenderTests
 {
-    public struct TestData
+    public class TestData
     {
         public string stringData;
         public int numberData;
@@ -26,8 +26,15 @@ public class TestReceiver : MonoBehaviour, IObserver<TestData>
     {
         public TestData data { get; private set; }
 
-        public void OnCompleted() { }
-        public void OnError(Exception error) { }
+        public void OnCompleted()
+        {
+            // Do nothing because test
+        }
+
+        public void OnError(Exception error)
+        {
+            // Do nothing because test
+        }
 
         public void OnNext(TestData value)
         {

Tests/Runtime/RandomExtensionTests.cs

@@ -9,7 +9,7 @@ public class RandomExtensionTests
     [Test]
     public void RandomWorks()
     {
-        int[] numbers = new int[] { 1, 2, 3, 4, 5 };
+        int[] numbers = new[] { 1, 2, 3, 4, 5 };
         Debug.Log(numbers.Random());
         Debug.Log(numbers.Random());
     }
@@ -30,14 +30,14 @@ public Item(string name, int percent)
     public void RandomPercent()
     {
         // Arrange
-        Item[] items = new Item[] {
+        Item[] items = new[] {
             new Item("normal sword", 80),
             new Item("epic sword", 19),
             new Item("regendary sword", 1),
         };
 
         int gotchaCount = 1000;
-        Dictionary<string, int> hasItemCount = new Dictionary<string, int>()
+        Dictionary<string, int> hasItemCount = new Dictionary<string, int>
         {
             {"normal", 0}, {"epic", 0}, {"regendary", 0}
         };
@@ -61,20 +61,19 @@ public void RandomPercent()
         for (int i = 0; i < items.Length; i++)
         {
             Item item = items[i];
-            float errorRate = 0.2f;
+            float errorRate = 0.5f; // 랜덤에 걸리지 않기 위해 범위를 많이 넓힘
             int expectCount = (int)(gotchaCount * (item.percent / 100f));
             int errorRange = (int)(expectCount * errorRate);
             KeyValuePair<string, int> itemCount = hasItemCount.First(hasItem => item.name.StartsWith(hasItem.Key));
 
-            // 대부분 통과하나, 랜덤 확률에 의해 가끔 실패함..
-            // Assert.GreaterOrEqual(itemCount.Value, expectCount - errorRange);
+            Assert.GreaterOrEqual(itemCount.Value, expectCount - errorRange);
         }
     }
 
     [Test]
     public void RandomFilter()
     {
-        int[] numbers = new int[] { 1, 2, 3, 4, 5 };
+        int[] numbers = new[] { 1, 2, 3, 4, 5 };
         HashSet<int> set = new HashSet<int>();
 
         for (int i = 0; i < numbers.Length; i++)

Tests/Runtime/SimplePoolTests.cs

@@ -8,7 +8,7 @@ public class SimplePoolTests
 {
     public class SimplePoolTarget
     {
-        public static int instanceCount { get; private set; } = 0;
+        public static int instanceCount { get; private set; }
 
         public static void Reset_InstanceCount()
         {
@@ -17,13 +17,13 @@ public static void Reset_InstanceCount()
 
         static public class Factory
         {
-            static public SimplePoolTarget CreateInstance()
+            static public SimplePoolTarget CreateInstance_FromFactory()
             {
                 return new SimplePoolTarget() { isCreateFromFactory = true };
             }
         }
 
-        public bool isCreateFromFactory { get; private set; } = false;
+        public bool isCreateFromFactory { get; private set; }
 
         public SimplePoolTarget()
         {
@@ -69,13 +69,13 @@ public void 사용예시()
 
     public class PoolEx : SimplePool<SimplePoolTarget>
     {
-        public PoolEx(int initializeSize = 0) : base(new SimplePoolTarget(), initializeSize)
+        public PoolEx(int initializeSize) : base(new SimplePoolTarget(), initializeSize)
         {
         }
 
         protected override SimplePoolTarget OnRequireNewInstance(SimplePoolTarget originItem)
         {
-            return SimplePoolTarget.Factory.CreateInstance();
+            return SimplePoolTarget.Factory.CreateInstance_FromFactory();
         }
     }