Get rid of JCommander dependency

Author: pesse

pom.xml

@@ -39,12 +39,6 @@
               </exclusion>
           </exclusions>
       </dependency>
-      <dependency>
-          <groupId>com.beust</groupId>
-          <artifactId>jcommander</artifactId>
-          <version>1.72</version>
-          <scope>compile</scope>
-      </dependency>
       <dependency>
           <groupId>com.zaxxer</groupId>
           <artifactId>HikariCP</artifactId>

src/main/java/org/utplsql/cli/ConnectionInfo.java

@@ -1,25 +1,6 @@
 package org.utplsql.cli;
 
-import com.beust.jcommander.IStringConverter;
-
 public class ConnectionInfo {
 
     public static final String COMMANDLINE_PARAM_DESCRIPTION = "<user>/<password>@//<host>[:<port>]/<service> OR <user>/<password>@<TNSName> OR <user>/<password>@<host>:<port>:<SID>";
-    private final String connectionInfo;
-
-    public ConnectionInfo(String connectionInfo) {
-        this.connectionInfo = connectionInfo;
-    }
-
-    public String getConnectionString() {
-        return connectionInfo;
-    }
-
-    public static class ConnectionStringConverter implements IStringConverter<ConnectionInfo> {
-
-        @Override
-        public ConnectionInfo convert(String s) {
-            return new ConnectionInfo(s);
-        }
-    }
 }

src/main/java/org/utplsql/cli/DataSourceProvider.java

@@ -1,6 +1,5 @@
 package org.utplsql.cli;
 
-import com.zaxxer.hikari.HikariDataSource;
 import org.utplsql.cli.datasource.TestedDataSourceProvider;
 
 import javax.sql.DataSource;
@@ -21,10 +20,6 @@ public class DataSourceProvider {
         }
     }
 
-    public static DataSource getDataSource(ConnectionInfo info, int maxConnections ) throws SQLException {
-        return getDataSource(info.getConnectionString(), maxConnections);
-    }
-
     public static DataSource getDataSource(String connectString, int maxConnections ) throws SQLException {
 
         requireOjdbc();

src/test/java/org/utplsql/cli/TestHelper.java

@@ -62,7 +62,7 @@ static int runApp(String... args) {
     }
 
     static Version getFrameworkVersion() throws SQLException {
-        DataSource ds = DataSourceProvider.getDataSource(new ConnectionInfo(TestHelper.getConnectionString()), 1);
+        DataSource ds = DataSourceProvider.getDataSource(TestHelper.getConnectionString(), 1);
         try (Connection con = ds.getConnection() ) {
             return DBHelper.getDatabaseFrameworkVersion(con);
         }