Merge pull request #95 from utPLSQL/bugfix/coverage_html_assets_subfolder

CoverageHTML Reporter will now reference its assets correctly 

when output is written to a subfolder.

Author: pesse

src/main/java/org/utplsql/cli/reporters/LocalAssetsCoverageHTMLReporter.java

@@ -6,6 +6,7 @@
 import org.utplsql.api.reporter.ReporterFactory;
 import org.utplsql.cli.ReporterOptions;
 
+import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.sql.Connection;
 import java.sql.SQLException;
@@ -27,15 +28,34 @@ public LocalAssetsCoverageHTMLReporter(String selfType, Object[] attributes) {
     public Reporter init(Connection con, CompatibilityProxy compatibilityProxy, ReporterFactory reporterFactory) throws SQLException {
         super.init(con, compatibilityProxy, reporterFactory);
 
-        if ( options != null && options.outputToFile() )
-            writeReportAssetsTo(Paths.get(getAssetsPath()));
+        if ( hasOutputToFile() ) {
+            writeReportAssetsTo(getPhysicalAssetPath());
+        }
 
         return this;
     }
 
+    private String getNameOfOutputFile() {
+        Path outputPath = Paths.get(options.getOutputFileName());
+        return outputPath.getName(outputPath.getNameCount()-1).toString();
+    }
+
+    private Path getPhysicalAssetPath() {
+        Path outputPath = Paths.get(options.getOutputFileName());
+        if ( outputPath.getNameCount() > 1 )
+            return outputPath.getParent().resolve(getAssetsPath());
+        else
+            return Paths.get(getAssetsPath());
+    }
+
     private void setAssetsPathFromOptions() {
-        if ( options != null && options.outputToFile() )
-            setAssetsPath(options.getOutputFileName()+"_assets/");
+        if ( hasOutputToFile() ) {
+            setAssetsPath(getNameOfOutputFile() + "_assets/");
+        }
+    }
+
+    private boolean hasOutputToFile() {
+        return (options != null && options.outputToFile());
     }
 
     @Override

src/test/java/org/utplsql/cli/RunCommandCoverageReporterIT.java

@@ -109,4 +109,26 @@ public void coverageReporterWriteAssetsToOutput() throws Exception {
         assertTrue(content.contains("<title>Code coverage</title>"));
     }
 
+    @Test
+    public void coverageReporterWriteAssetsToSubfolder() throws Exception {
+
+        Path origCoveratePath = getTempCoverageFilePath();
+        Path coveragePath = Paths.get(origCoveratePath.toString(), origCoveratePath.toString());
+        Path coverageAssetsPath = Paths.get(coveragePath.toString() + "_assets");
+
+        TestHelper.runApp("run", TestHelper.getConnectionString(),
+                "-f=ut_coverage_html_reporter", "-o=" + coveragePath, "-s");
+
+
+        // Check application file exists
+        File applicationJs = coverageAssetsPath.resolve(Paths.get("application.js")).toFile();
+        assertTrue(applicationJs.exists());
+
+        // Check correct script-part in HTML source exists
+        String content = new String(Files.readAllBytes(coveragePath));
+        assertTrue(content.contains("<script src='" + origCoveratePath.toString() + "_assets" + "/application.js'"));
+
+        // Check correct title exists
+        assertTrue(content.contains("<title>Code coverage</title>"));
+    }
 }