Test placeholders #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycedres
force-pushed
the
test-placeholders
branch
from
e623f8c to
39972a2
Compare
ycedres
force-pushed
the
test-placeholders
branch
2 times, most recently
from
37184fb to
d5b9ea1
Compare
ycedres
force-pushed
the
test-placeholders
branch
from
d5b9ea1 to
15005fb
Compare
This was referenced Nov 19, 2025
Closed
cbbayburt
reviewed
Nov 26, 2025
src/mcp_server_uyuni/server.py
Outdated
| logger.info(log_string) | ||
| await ctx.info(log_string) | ||
|
|
||
| is_confirmed = str(confirm).lower() == 'true' |
Contributor
There was a problem hiding this comment.
This confirmed check looks different than the others. Can we extract the following parsing logic to a helper method to unify it and avoid repetition?
is_confirmed = str(confirm).lower() in ('true', 'yes', '1')
test/test_cases_ops.json
Outdated
| { | ||
| "id": "TC-OPS-001_confirm_request", | ||
| "prompt": "Add a new system at host 10.145.211.203 with activation key '1-DEBLIKE-KEY'", | ||
| "prompt": "Can you add a new system at host {new_system_host} with activation key '{key_deblike}'?", |
Contributor
There was a problem hiding this comment.
Using the imperative "Do this .." instead of "Can you do this .." feels more natural IMO. What's the reason we prefer this way?
Contributor
Author
There was a problem hiding this comment.
You're right, I was using Gemini to batch refactor and replace fixed values with placeholders and I did not realise it changed also this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is improving the test runner and the test results. At this point some more automatic testing improvement is needed but this is a step forward.
Add placeholders to allow easier test configuration.
Improve judge model system prompt.
Improve confirmation mechanism for write-enabled tools (this allows confirmation mechanism of testing to also work).
Included patch produced in (so related tests pass)
Fix nested tool calls #34