Add compatibility test with Valkey 7.2/8.0 (#2342)

* Add cross version compatibility test to run with Valkey 7.2 and 8.0
* Add mechanism in TCL test to skip tests dynamically - #2711

---------

Signed-off-by: Harkrishn Patro <harkrisp@amazon.com>
Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech>

Author: hpatro

.github/workflows/ci.yml

@@ -28,17 +28,12 @@ jobs:
         # Fail build if there are warnings
         # build with TLS just for compilation coverage
         run: make -j4 all-with-unit-tests SERVER_CFLAGS='-Werror' BUILD_TLS=yes USE_FAST_FLOAT=yes
-      - name: install old server for compatibility testing
-        run: |
-          cd tests/tmp
-          wget https://download.valkey.io/releases/valkey-8.1.3-noble-x86_64.tar.gz
-          tar -xvf valkey-8.1.3-noble-x86_64.tar.gz
       - name: test
         run: |
           sudo apt-get install tcl8.6 tclx
-          ./runtest --verbose --tags -slow --dump-logs --other-server-path tests/tmp/valkey-8.1.3-noble-x86_64/bin/valkey-server
+          ./runtest --verbose --tags -slow --dump-logs
       - name: module api test
-        run: CFLAGS='-Werror' ./runtest-moduleapi --verbose --dump-logs --other-server-path tests/tmp/valkey-8.1.3-noble-x86_64/bin/valkey-server
+        run: CFLAGS='-Werror' ./runtest-moduleapi --verbose --dump-logs
       - name: validate commands.def up to date
         run: |
           touch src/commands/ping.json
@@ -49,6 +44,40 @@ jobs:
         run: |
           ./src/valkey-unit-tests
 
+  test-ubuntu-latest-compatibility:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        server:
+          - {version: "7.2.10", file: "valkey-7.2.10-noble-x86_64.tar.gz"}
+          - {version: "8.0.4", file: "valkey-8.0.4-noble-x86_64.tar.gz"}
+          - {version: "8.1.3", file: "valkey-8.1.3-noble-x86_64.tar.gz"}
+    steps:
+      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - name: make
+        # Fail build if there are warnings
+        # build with TLS just for compilation coverage
+        run: make -j4 all-with-unit-tests SERVER_CFLAGS='-Werror' BUILD_TLS=yes USE_FAST_FLOAT=yes
+
+      - name: Install old server (${{ matrix.server.version }}) for compatibility testing
+        run: |
+          mkdir -p tests/tmp
+          cd tests/tmp
+          wget https://download.valkey.io/releases/${{ matrix.server.file }}
+          tar -xvf ${{ matrix.server.file }}
+
+      - name: Run compatibility tests against ${{ matrix.server.version }}
+        run: |
+          sudo apt-get install -y tcl8.6 tclx
+          ./runtest --verbose --tags "-slow needs:other-server" --dump-logs \
+            --other-server-path tests/tmp/valkey-${{ matrix.server.version }}-noble-x86_64/bin/valkey-server
+
+      - name: Module API tests against ${{ matrix.server.version }}
+        run: |
+          CFLAGS='-Werror' ./runtest-moduleapi --tags needs:other-server --verbose --dump-logs \
+            --other-server-path tests/tmp/valkey-${{ matrix.server.version }}-noble-x86_64/bin/valkey-server
+
   test-ubuntu-latest-cmake:
     runs-on: ubuntu-latest
     steps:

tests/support/test.tcl

@@ -10,6 +10,10 @@ proc fail {msg} {
     error "assertion:$msg"
 }
 
+proc skip {msg} {
+    error "skipped:$msg"
+}
+
 proc assert {condition} {
     if {![uplevel 1 [list expr $condition]]} {
         set context "(context: [info frame -1])"
@@ -256,7 +260,12 @@ proc test {name code {okpattern undefined} {tags {}}} {
     set test_start_time [clock milliseconds]
     if {[catch {set retval [uplevel 1 $code]} error]} {
         set assertion [string match "assertion:*" $error]
-        if {$assertion || $::durable} {
+        set skip [string match "skipped:*" $error]
+        if {$skip} {
+            incr ::num_skipped
+            set msg [string range $error 8 end]
+            send_data_packet $::test_server_fd skip "$::cur_test: $msg"
+        } elseif {$assertion || $::durable} {
             # durable prevents the whole tcl test from exiting on an exception.
             # an assertion is handled gracefully anyway.
             set msg [string range $error 10 end]

tests/unit/cluster/cross-version-cluster.tcl

@@ -16,7 +16,13 @@ tags {external:skip needs:other-server cluster singledb} {
             set primary_port [srv 0 port]
             set primary_id [$primary cluster myid]
 
-            start_server {config "minimal-cluster.conf" start-other-server 1 overrides {cluster-ping-interval 1000 rdb-version-check relaxed}} {
+            start_server {config "minimal-cluster.conf" start-other-server 1 overrides {cluster-ping-interval 1000}} {
+                set res [dict get [r hello] version]
+                assert [regexp {([0-9]+)\.([0-9]+)\.[0-9]+} $res -> major minor]
+                if {($major < 8) || ($major == 8 && $minor < 1)} {
+                    skip "Requires Valkey 8.1 or above"
+                }
+                r config set rdb-version-check relaxed
                 # Add a replica of the old version to the cluster
                 r cluster meet $primary_host $primary_port
                 wait_for_cluster_propagation