Skip to content

Commit 8b0f138

Browse files
authored
Merge branch 'main' into deps
2 parents 9a4f0f6 + a810cd0 commit 8b0f138

File tree

4 files changed

+23
-18
lines changed

4 files changed

+23
-18
lines changed

packages/@core/ui-kit/shadcn-ui/src/ui/tree/tree.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ defineExpose({
380380
<div class="flex items-center gap-1">
381381
<Checkbox
382382
v-if="multiple"
383-
:checked="isSelected && !isNodeDisabled(item)"
383+
:model-value="isSelected && !isNodeDisabled(item)"
384384
:disabled="isNodeDisabled(item)"
385385
:indeterminate="isIndeterminate && !isNodeDisabled(item)"
386386
@click="

packages/effects/common-ui/src/components/icon-picker/icon-picker.vue

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,17 +71,10 @@ const modelValue = defineModel({ default: '', type: String });
7171
7272
const visible = ref(false);
7373
const currentSelect = ref('');
74-
const currentPage = ref(1);
7574
const keyword = ref('');
7675
const keywordDebounce = refDebounced(keyword, 300);
7776
const innerIcons = ref<string[]>([]);
7877
79-
/* 当检索关键词变化时,重置分页 */
80-
watch(keywordDebounce, () => {
81-
currentPage.value = 1;
82-
setCurrentPage(1);
83-
});
84-
8578
watchDebounced(
8679
() => props.prefix,
8780
async (prefix) => {
@@ -122,7 +115,7 @@ const showList = computed(() => {
122115
);
123116
});
124117
125-
const { paginationList, total, setCurrentPage } = usePagination(
118+
const { paginationList, total, setCurrentPage, currentPage } = usePagination(
126119
showList,
127120
props.pageSize,
128121
);
@@ -145,7 +138,6 @@ const handleClick = (icon: string) => {
145138
};
146139
147140
const handlePageChange = (page: number) => {
148-
currentPage.value = page;
149141
setCurrentPage(page);
150142
};
151143

packages/effects/hooks/src/use-pagination.ts

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { Ref } from 'vue';
22

3-
import { computed, ref, unref } from 'vue';
3+
import { computed, ref, unref, watch } from 'vue';
44

55
/**
66
* Paginates an array of items
@@ -22,7 +22,11 @@ function pagination<T = any>(list: T[], pageNo: number, pageSize: number): T[] {
2222
return ret;
2323
}
2424

25-
export function usePagination<T = any>(list: Ref<T[]>, pageSize: number) {
25+
export function usePagination<T = any>(
26+
list: Ref<T[]>,
27+
pageSize: number,
28+
totalChangeToFirstPage = true,
29+
) {
2630
const currentPage = ref(1);
2731
const pageSizeRef = ref(pageSize);
2832

@@ -38,11 +42,21 @@ export function usePagination<T = any>(list: Ref<T[]>, pageSize: number) {
3842
return unref(list).length;
3943
});
4044

45+
if (totalChangeToFirstPage) {
46+
watch(total, () => {
47+
setCurrentPage(1);
48+
});
49+
}
50+
4151
function setCurrentPage(page: number) {
42-
if (page < 1 || page > unref(totalPages)) {
43-
throw new Error('Invalid page number');
52+
if (page === 1 && unref(totalPages) === 0) {
53+
currentPage.value = 1;
54+
} else {
55+
if (page < 1 || page > unref(totalPages)) {
56+
throw new Error('Invalid page number');
57+
}
58+
currentPage.value = page;
4459
}
45-
currentPage.value = page;
4660
}
4761

4862
function setPageSize(pageSize: number) {
@@ -54,5 +68,5 @@ export function usePagination<T = any>(list: Ref<T[]>, pageSize: number) {
5468
currentPage.value = 1;
5569
}
5670

57-
return { setCurrentPage, total, setPageSize, paginationList };
71+
return { setCurrentPage, total, setPageSize, paginationList, currentPage };
5872
}

playground/src/views/system/menu/modules/form.vue

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ const schema: VbenFormSchema[] = [
107107
componentProps() {
108108
// 不需要处理多语言时就无需这么做
109109
return {
110-
addonAfter: titleSuffix.value,
110+
...(titleSuffix.value && { addonAfter: titleSuffix.value }),
111111
onChange({ target: { value } }: ChangeEvent) {
112112
titleSuffix.value = value && $te(value) ? $t(value) : undefined;
113113
},
@@ -442,7 +442,6 @@ const [Form, formApi] = useVbenForm({
442442
showDefaultActions: false,
443443
wrapperClass: 'grid-cols-2 gap-x-4',
444444
});
445-
446445
const [Drawer, drawerApi] = useVbenDrawer({
447446
onConfirm: onSubmit,
448447
onOpenChange(isOpen) {

0 commit comments

Comments
 (0)