refactor: skip hook filter inject in build

Author: sapphi-red

packages/vite/src/node/build.ts

@@ -81,10 +81,6 @@ import {
 } from './baseEnvironment'
 import type { MinimalPluginContext, Plugin, PluginContext } from './plugin'
 import type { RollupPluginHooks } from './typeUtils'
-import {
-  createFilterForTransform,
-  createIdFilter,
-} from './plugins/pluginFilter'
 import { buildOxcPlugin } from './plugins/oxc'
 
 export interface BuildEnvironmentOptions {
@@ -597,7 +593,7 @@ async function buildEnvironment(
   // inject environment and ssr arg to plugin load/transform hooks
   const chunkMetadataMap = new Map<string, ChunkMetadata>()
   const plugins = environment.plugins.map((p) =>
-    injectEnvironmentAndFilterToHooks(environment, chunkMetadataMap, p),
+    injectEnvironmentToHooks(environment, chunkMetadataMap, p),
   )
 
   const rollupOptions: RolldownOptions = {
@@ -1157,7 +1153,7 @@ function isExternal(id: string, test: string | RegExp) {
   }
 }
 
-export function injectEnvironmentAndFilterToHooks(
+export function injectEnvironmentToHooks(
   environment: BuildEnvironment,
   chunkMetadataMap: Map<string, ChunkMetadata>,
   plugin: Plugin,
@@ -1169,13 +1165,13 @@ export function injectEnvironmentAndFilterToHooks(
   for (const hook of Object.keys(clone) as RollupPluginHooks[]) {
     switch (hook) {
       case 'resolveId':
-        clone[hook] = wrapEnvironmentAndFilterResolveId(environment, resolveId)
+        clone[hook] = wrapEnvironmentResolveId(environment, resolveId)
         break
       case 'load':
-        clone[hook] = wrapEnvironmentAndFilterLoad(environment, load)
+        clone[hook] = wrapEnvironmentLoad(environment, load)
         break
       case 'transform':
-        clone[hook] = wrapEnvironmentAndFilterTransform(environment, transform)
+        clone[hook] = wrapEnvironmentTransform(environment, transform)
         break
       default:
         if (ROLLUP_HOOKS.includes(hook)) {
@@ -1193,20 +1189,14 @@ export function injectEnvironmentAndFilterToHooks(
   return clone
 }
 
-function wrapEnvironmentAndFilterResolveId(
+function wrapEnvironmentResolveId(
   environment: BuildEnvironment,
   hook?: Plugin['resolveId'],
 ): Plugin['resolveId'] {
   if (!hook) return
 
-  const rawIdFilter = typeof hook === 'object' ? hook.filter?.id : undefined
-  const idFilter = rawIdFilter ? createIdFilter(rawIdFilter) : undefined
-
   const fn = getHookHandler(hook)
   const handler: Plugin['resolveId'] = function (id, importer, options) {
-    if (idFilter && !idFilter(id)) {
-      return
-    }
     return fn.call(
       injectEnvironmentInContext(this, environment),
       id,
@@ -1225,20 +1215,14 @@ function wrapEnvironmentAndFilterResolveId(
   }
 }
 
-function wrapEnvironmentAndFilterLoad(
+function wrapEnvironmentLoad(
   environment: BuildEnvironment,
   hook?: Plugin['load'],
 ): Plugin['load'] {
   if (!hook) return
 
-  const rawIdFilter = typeof hook === 'object' ? hook.filter?.id : undefined
-  const idFilter = rawIdFilter ? createIdFilter(rawIdFilter) : undefined
-
   const fn = getHookHandler(hook)
   const handler: Plugin['load'] = function (id, ...args) {
-    if (idFilter && !idFilter(id)) {
-      return
-    }
     return fn.call(
       injectEnvironmentInContext(this, environment),
       id,
@@ -1256,22 +1240,14 @@ function wrapEnvironmentAndFilterLoad(
   }
 }
 
-function wrapEnvironmentAndFilterTransform(
+function wrapEnvironmentTransform(
   environment: BuildEnvironment,
   hook?: Plugin['transform'],
 ): Plugin['transform'] {
   if (!hook) return
 
-  const filters = typeof hook === 'object' ? hook.filter : undefined
-  const filter = filters
-    ? createFilterForTransform(filters.id, filters.code)
-    : undefined
-
   const fn = getHookHandler(hook)
   const handler: Plugin['transform'] = function (code, importer, ...args) {
-    if (filter && !filter(importer, code)) {
-      return
-    }
     return fn.call(
       injectEnvironmentInContext(this, environment),
       code,

packages/vite/src/node/plugins/worker.ts

@@ -17,7 +17,7 @@ import {
 import {
   BuildEnvironment,
   createToImportMetaURLBasedRelativeRuntime,
-  injectEnvironmentAndFilterToHooks,
+  injectEnvironmentToHooks,
   onRollupLog,
   toOutputFilePathInJS,
 } from '../build'
@@ -98,7 +98,7 @@ async function bundleWorkerEntry(
     ...rollupOptions,
     input,
     plugins: workerEnvironment.plugins.map((p) =>
-      injectEnvironmentAndFilterToHooks(workerEnvironment, chunkMetadataMap, p),
+      injectEnvironmentToHooks(workerEnvironment, chunkMetadataMap, p),
     ),
     onLog(level, log) {
       onRollupLog(level, log, workerEnvironment)