clang-tidy + fix tests

Author: schaumb

src/base/math/renard.h

@@ -18,7 +18,7 @@ class Renard
 	[[nodiscard]] double floor(double value) const;
 
 private:
-	std::span<const double> numbers;
+	std::span<const double> numbers{};
 };
 
 }

src/chart/generator/axis.cpp

@@ -1,19 +1,18 @@
 #include "axis.h"
 
-#include <__compare/compare_three_way.h>
 #include <algorithm>
 #include <cmath>
 #include <compare>
 #include <cstddef>
 #include <cstdint>
-#include <functional>
 #include <limits>
 #include <memory>
 #include <optional>
 #include <string>
 #include <string_view>
 #include <tuple>
 #include <utility>
+#include <vector>
 
 #include "base/alg/merge.h"
 #include "base/anim/interpolated.h"
@@ -338,9 +337,6 @@ DimensionAxis interpolate(const DimensionAxis &op0,
 	                  const Val &rhs,
 	                  const Val::first_type *key = nullptr) -> Val
 	{
-		printf("%s to %s\n",
-		    DimensionAxis::mergedLabels(lhs.first).c_str(),
-		    DimensionAxis::mergedLabels(rhs.first).c_str());
 		return {key ? *key : lhs.first,
 		    interpolate(lhs.second, rhs.second, factor)};
 	};

src/chart/generator/axis.h

@@ -188,13 +188,13 @@ struct DimensionAxis
 	[[nodiscard]] static std::string mergedLabels(
 	    const std::vector<Data::SliceIndex> &slices)
 	{
-		return {std::from_range,
+		return std::ranges::to<std::string>(
 		    std::views::transform(slices,
 		        [](const Data::SliceIndex &slice)
 		        {
 			        return ", " + slice.*which;
 		        })
-		        | std::views::join | std::views::drop(2)};
+		    | std::views::join | std::views::drop(2));
 	}
 
 private:

src/chart/generator/plotbuilder.cpp

@@ -462,14 +462,14 @@ void PlotBuilder::calcLegendAndLabel(const Data::DataTable &dataTable)
 			if (auto &&series = plot->getOptions()->labelSeries(type);
 			    !series.empty() && isAutoTitle
 			    && calcLegend.dimension.empty())
-				calcLegend.title = std::string{std::from_range,
+				calcLegend.title = std::ranges::to<std::string>(
 				    series
-				        | std::views::transform(
-				            [](const Data::SeriesIndex &series)
-				            {
-					            return ", " + series.getColIndex();
-				            })
-				        | std::views::join | std::views::drop(2)};
+				    | std::views::transform(
+				        [](const Data::SeriesIndex &series)
+				        {
+					        return ", " + series.getColIndex();
+				        })
+				    | std::views::join | std::views::drop(2));
 		}
 	}
 
@@ -571,14 +571,14 @@ void PlotBuilder::calcAxis(const Data::DataTable &dataTable,
 		if (auto &&series = plot->getOptions()->labelSeries(type);
 		    !axis.dimension.setLabels(axisProps.step.getValue(1.0))
 		    && !series.empty() && isAutoTitle)
-			axis.title = std::string{std::from_range,
+			axis.title = std::ranges::to<std::string>(
 			    series
-			        | std::views::transform(
-			            [](const Data::SeriesIndex &series)
-			            {
-				            return ", " + series.getColIndex();
-			            })
-			        | std::views::join | std::views::drop(2)};
+			    | std::views::transform(
+			        [](const Data::SeriesIndex &series)
+			        {
+				        return ", " + series.getColIndex();
+			        })
+			    | std::views::join | std::views::drop(2));
 		for (std::uint32_t pos{};
 		     DimensionAxis::Item & i : axis.dimension.sortedItems())
 			i.endPos = i.startPos =

src/chart/options/channel.h

@@ -195,17 +195,28 @@ struct Channel
 		[[nodiscard]] auto operator<=>(
 		    const LabelLevelList &) const = default;
 
-		LabelLevelList(std::size_t one) : levels{one} {}
-		template <class T> LabelLevelList(T &&) = delete;
+		explicit LabelLevelList(std::size_t one) : levels{one} {}
+		LabelLevelList(const LabelLevelList &) = default;
+		LabelLevelList(LabelLevelList &&) noexcept = default;
+		LabelLevelList &operator=(const LabelLevelList &) = default;
+		LabelLevelList &operator=(
+		    LabelLevelList &&) noexcept = default;
+
+		template <class T>
+		    requires(!std::is_same_v<std::remove_cvref_t<T>,
+		                LabelLevelList>)
+		// NOLINTNEXTLINE(cppcoreguidelines-missing-std-forward)
+		explicit LabelLevelList(T &&) = delete;
 
 		explicit LabelLevelList(std::vector<std::size_t> &&levels) :
 		    levels(std::move(levels))
 		{}
 
 		static LabelLevelList fromString(const std::string &str)
 		{
-			return LabelLevelList{{std::from_range,
-			    std::string_view{str} | std::views::split(',')
+			return LabelLevelList{
+			    std::ranges::to<std::vector<std::size_t>>(
+			        std::string_view{str} | std::views::split(',')
 			        | std::views::transform(
 			            [](const auto &s)
 			            {
@@ -222,7 +233,7 @@ struct Channel
 				                range.end(),
 				                ix);
 				            return ix;
-			            })}};
+			            }))};
 		}
 
 		[[nodiscard]] std::string toString() const

src/chart/options/options.cpp

@@ -1,6 +1,7 @@
 
 #include "options.h"
 
+#include <algorithm>
 #include <atomic>
 #include <cstddef>
 #include <iterator>

src/chart/options/options.h

@@ -107,10 +107,10 @@ class Options : public OptionProperties
 		}
 		else if (!lll && !hasMeasure && ch.dimensions().size() > 1
 		         && channel == legend.get().getValueOrAuto()) {
-			lll.emplace(
-			    Channel::LabelLevelList{std::vector{std::from_range,
+			lll.emplace(Channel::LabelLevelList{
+			    std::ranges::to<std::vector<std::size_t>>(
 			        std::views::iota(std::size_t{},
-			            ch.dimensions().size())}});
+			            ch.dimensions().size()))});
 		}
 		else if (!lll) {
 			lll.emplace(std::size_t{0});
@@ -159,7 +159,9 @@ class Options : public OptionProperties
 		}
 		if (auto &&measure = ch.measure();
 		    measure
-		    && ch.labelLevel.getValue(std::size_t{}).levels
+		    && ch.labelLevel
+		               .getValue(Channel::LabelLevelList{size_t{}})
+		               .levels
 		           == std::vector{std::size_t{}})
 			return {*measure};
 		return {};

src/chart/rendering/drawaxes.cpp

@@ -28,7 +28,6 @@
 #include "chart/main/events.h"
 #include "chart/main/style.h"
 #include "chart/options/channel.h"
-#include "dataframe/old/types.h"
 
 #include "drawguides.h"
 #include "drawinterlacing.h"

src/chart/rendering/drawlegend.cpp

@@ -7,6 +7,7 @@
 #include <functional>
 #include <string>
 #include <utility>
+#include <vector>
 
 #include "base/anim/interpolated.h"
 #include "base/geom/affinetransform.h"

test/e2e/test_cases/test_cases.json

@@ -56,7 +56,7 @@
 			"refs": ["bc224eb"]
 		},
 		"basic_animations/legend_transitions/color_2discrete_anim": {
-			"refs": ["86f503c"]
+			"refs": ["71a45d2"]
 		},
 		"basic_animations/legend_transitions/color_conti_anim": {
 			"refs": ["106245c"]
@@ -80,7 +80,7 @@
 			"refs": ["0617129"]
 		},
 		"basic_animations/legend_transitions/lightness_2discrete_anim": {
-			"refs": ["3e29b58"]
+			"refs": ["f818429"]
 		},
 		"basic_animations/legend_transitions/lightness_conti_anim": {
 			"refs": ["e65d2ff"]
@@ -299,7 +299,7 @@
 			"refs": ["b627ce9"]
 		},
 		"operations/orientation_tutorial_data/line_orientation": {
-			"refs": ["dc9ac6c"]
+			"refs": ["156df8d"]
 		},
 		"operations/orientation_tutorial_data/rectangle_orientation": {
 			"refs": ["a97572f"]