fix(pre-commit): mdformat

Author: AlonKellner-RedHat

tests/unit/scheduler/OVER_SATURATION_TEST_COVERAGE.md

@@ -6,9 +6,7 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 
 ## Test Summary
 
-**Total Tests**: 81 (48 original + 33 comprehensive)
-**Coverage Areas**: 8 major test classes
-**Test Types**: Statistical accuracy, robustness, performance, integration, edge cases
+**Total Tests**: 81 (48 original + 33 comprehensive) **Coverage Areas**: 8 major test classes **Test Types**: Statistical accuracy, robustness, performance, integration, edge cases
 
 ## Test Coverage Breakdown
 
@@ -17,6 +15,7 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 **Purpose**: Validate the mathematical correctness of the slope detection algorithm.
 
 **Tests (7)**:
+
 - `test_approx_t_ppf_accuracy`: Validates t-distribution approximation accuracy
 - `test_approx_t_ppf_edge_cases`: Tests t-distribution edge cases (invalid df, extremes)
 - `test_slope_calculation_perfect_line`: Tests perfect linear data detection
@@ -26,6 +25,7 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 - `test_margin_of_error_calculation`: Validates confidence interval calculations
 
 **Key Validations**:
+
 - T-distribution approximation within expected bounds
 - Perfect slope detection (y = 2x + 1 → slope ≈ 2.0)
 - Zero slope properly handled (horizontal lines)
@@ -37,6 +37,7 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 **Purpose**: Ensure detector handles various data conditions without crashing.
 
 **Tests (6)**:
+
 - `test_detector_with_empty_data`: No data scenarios
 - `test_detector_with_single_request`: Insufficient data handling
 - `test_detector_with_identical_values`: Zero variance scenarios
@@ -45,6 +46,7 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 - `test_detector_window_management_stress`: Large dataset memory management
 
 **Key Validations**:
+
 - Graceful handling of empty datasets
 - No false positives with flat/identical data
 - Numerical stability with extreme values
@@ -56,12 +58,14 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 **Purpose**: Test detector with realistic request patterns.
 
 **Tests (4)**:
+
 - `test_gradual_performance_degradation`: Slowly degrading performance
 - `test_sudden_load_spike`: Sudden performance drops
 - `test_variable_but_stable_performance`: Noisy but stable systems
 - `test_recovery_after_degradation`: Recovery scenarios
 
 **Key Validations**:
+
 - Detects gradual TTFT increases (1.0 → 6.0 over 50 requests)
 - Detects sudden spikes (5 → 50 concurrent, 1.0 → 5.0 TTFT)
 - No false positives with variable but stable performance
@@ -72,11 +76,13 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 **Purpose**: Test integration between detector and constraint components.
 
 **Tests (3)**:
+
 - `test_constraint_metadata_completeness`: Validates complete metadata output
 - `test_constraint_with_realistic_request_flow`: 60-second realistic simulation
 - `test_constraint_disabled_never_stops`: Disabled constraint behavior
 
 **Key Validations**:
+
 - All required metadata fields present (`is_over_saturated`, slopes, violations, etc.)
 - Realistic 180-request simulation over 60 seconds
 - Disabled constraints never stop regardless of saturation
@@ -87,10 +93,12 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 **Purpose**: Validate performance characteristics and efficiency.
 
 **Tests (2)**:
+
 - `test_detector_memory_usage`: Memory bounds with 10,000 requests
 - `test_detector_computational_efficiency`: 100 check_alert() calls < 1 second
 
 **Key Validations**:
+
 - Memory usage bounded (< 2000 requests in memory)
 - 100 detection calls complete in < 1 second
 - O(1) operations maintain efficiency at scale
@@ -100,12 +108,14 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 **Purpose**: Test constraint factory and initialization robustness.
 
 **Tests (4)**:
+
 - `test_initializer_parameter_validation`: Parameter passing validation
 - `test_initializer_with_extreme_parameters`: Extreme but valid parameters
 - `test_initializer_alias_precedence`: Alias resolution order
 - `test_constraint_creation_with_mock_detector`: Isolated constraint testing
 
 **Key Validations**:
+
 - Parameters correctly passed to detector
 - Extreme values (0.1s minimum, 3600s window) handled
 - Alias precedence (`stop_over_sat` overrides `stop_over_saturated=False`)
@@ -116,6 +126,7 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 **Purpose**: Test edge cases and prevent regression bugs.
 
 **Tests (7)**:
+
 - `test_detector_with_malformed_request_data`: Required field validation
 - `test_constraint_with_missing_timings_data`: Missing timing data handling
 - `test_detector_concurrent_modification_safety`: Concurrent-like access patterns
@@ -125,6 +136,7 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 - `test_ttft_violation_counting_accuracy`: TTFT threshold counting accuracy
 
 **Key Validations**:
+
 - Required fields properly validated (KeyError on missing data)
 - Graceful handling of requests without timing data
 - Robust handling of concurrent-like modifications
@@ -136,12 +148,14 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 ## Test Categories by Pytest Markers
 
 ### Smoke Tests (`@pytest.mark.smoke`)
+
 - **Count**: 15 tests
 - **Purpose**: Quick validation of core functionality
 - **Runtime**: < 30 seconds total
 - **Focus**: Basic initialization, core algorithms, critical paths
 
 ### Sanity Tests (`@pytest.mark.sanity`)
+
 - **Count**: 21 tests
 - **Purpose**: Comprehensive validation of feature behavior
 - **Runtime**: 1-3 minutes total
@@ -150,26 +164,30 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 ## Coverage Metrics
 
 ### Algorithm Coverage
+
 - ✅ **T-distribution approximation**: Mathematical accuracy validated
 - ✅ **Slope calculation**: Linear regression with confidence intervals
 - ✅ **Window management**: Time-based pruning and memory bounds
 - ✅ **Threshold detection**: TTFT violations and concurrent request tracking
 - ✅ **Statistical significance**: Margin of error and confidence testing
 
 ### Integration Coverage
+
 - ✅ **Detector ↔ Constraint**: Proper data flow and decision making
 - ✅ **Constraint ↔ Scheduler**: State integration and action generation
 - ✅ **Factory ↔ Initializer**: Proper constraint creation and configuration
 - ✅ **Timing ↔ Detection**: Accurate duration and timing calculations
 
 ### Robustness Coverage
+
 - ✅ **Empty data**: No crashes or false positives
 - ✅ **Malformed data**: Proper validation and error handling
 - ✅ **Extreme values**: Numerical stability maintained
 - ✅ **Memory management**: Bounded growth under stress
 - ✅ **Performance**: Efficiency maintained at scale
 
 ### Scenario Coverage
+
 - ✅ **Gradual degradation**: Detected correctly
 - ✅ **Sudden spikes**: Detected correctly
 - ✅ **Stable performance**: No false positives
@@ -179,30 +197,35 @@ This document outlines the comprehensive unit test coverage for the over-saturat
 ## Maintainer Confidence Indicators
 
 ### ✅ **Mathematical Correctness**
+
 - T-distribution approximation validated against known values
 - Linear regression implementation verified with perfect test data
 - Confidence intervals calculated correctly
 - Statistical significance properly assessed
 
 ### ✅ **Production Readiness**
+
 - Memory usage bounded under stress (10,000+ requests)
 - Performance maintained (100 checks < 1 second)
 - Graceful degradation with malformed data
 - No crashes under extreme conditions
 
 ### ✅ **Feature Completeness**
+
 - All configuration parameters tested
 - All metadata fields validated
 - Enable/disable functionality verified
 - Factory and alias systems working
 
 ### ✅ **Integration Reliability**
+
 - 60-second realistic simulation passes
 - Proper scheduler state integration
 - Accurate timing calculations
 - Complete constraint lifecycle tested
 
 ### ✅ **Regression Protection**
+
 - Edge cases identified and tested
 - Numerical stability validated
 - State management verified

tests/unit/scheduler/test_over_saturation.py

@@ -20,6 +20,7 @@
     SchedulerState,
     SchedulerUpdateAction,
     SerializableConstraintInitializer,
+    SlopeChecker,
 )
 from guidellm.schemas import RequestInfo, RequestTimings
 
@@ -556,10 +557,6 @@ class TestSlopeChecker:
     @pytest.fixture
     def slope_checker(self):
         """Create a SlopeChecker instance for testing."""
-        from guidellm.scheduler.constraints.over_saturation import (
-            SlopeChecker,
-        )
-
         return SlopeChecker(moe_threshold=1.0, confidence=0.95)
 
     @pytest.mark.smoke

tests/unit/scheduler/test_over_saturation_comprehensive.py

@@ -8,6 +8,7 @@
 """
 
 import math
+import random
 import time
 from unittest.mock import Mock, patch
 
@@ -309,8 +310,6 @@ def test_variable_but_stable_performance(self):
             minimum_duration=5.0, minimum_window_size=10, moe_threshold=2.0
         )
 
-        import random
-
         random.seed(123)  # Reproducible
 
         # Variable but centered around stable values