Skip to content

Commit 4d6d85f

Browse files
authored
refactor(e2e): remove legacy mock/real vLLM test modes and Makefile targets (#421)
Signed-off-by: samzong <samzong.lu@gmail.com>
1 parent f79a63c commit 4d6d85f

File tree

2 files changed

+1
-59
lines changed

2 files changed

+1
-59
lines changed

e2e-tests/run_all_tests.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,6 @@ def main():
8989
)
9090
parser.add_argument("--pattern", default="*.py", help="Test file pattern to run")
9191
parser.add_argument("--verbose", "-v", action="store_true", help="Verbose output")
92-
parser.add_argument(
93-
"--mock", action="store_true", help="Running with mock vLLM servers"
94-
)
95-
parser.add_argument(
96-
"--real", action="store_true", help="Running with real vLLM servers"
97-
)
9892
args = parser.parse_args()
9993

10094
# Get the directory where this script is located
@@ -127,18 +121,6 @@ def main():
127121
print(f"No test files found matching pattern '{args.pattern}'")
128122
return 1
129123

130-
# Print test mode information
131-
if args.mock:
132-
print("\n🤖 Running in MOCK mode - using mock vLLM servers")
133-
print(" ✅ Fast execution, no GPU required")
134-
print(" ⚠️ Mock responses, not real model inference")
135-
elif args.real:
136-
print("\n🧠 Running in REAL mode - using actual vLLM servers")
137-
print(" 🚀 Real model inference and responses")
138-
print(" ⚠️ Requires GPU and longer execution time")
139-
else:
140-
print("\n🔍 Running in STANDARD mode - checking whatever is available")
141-
142124
print(f"\nRunning {len(test_files)} test files:")
143125
for file in test_files:
144126
print(f" - {file}")

tools/make/build-run-test.mk

Lines changed: 1 addition & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -113,50 +113,10 @@ start-llm-katan:
113113
@echo "Press Ctrl+C to stop servers"
114114
@./e2e-tests/start-llm-katan.sh
115115

116-
# Legacy: Start mock vLLM servers for testing (foreground mode for development)
117-
start-mock-vllm:
118-
@echo "Starting mock vLLM servers in foreground mode..."
119-
@echo "Press Ctrl+C to stop servers"
120-
@./e2e-tests/start-mock-servers.sh
121-
122-
# Start real vLLM servers for testing
123-
start-vllm:
124-
@echo "Starting real vLLM servers..."
125-
@./e2e-tests/start-vllm-servers.sh
126-
127-
# Stop real vLLM servers
128-
stop-vllm:
129-
@echo "Stopping real vLLM servers..."
130-
@./e2e-tests/stop-vllm-servers.sh
131-
132116
# Run e2e tests with LLM Katan (lightweight real models)
133117
test-e2e-vllm:
134118
@echo "Running e2e tests with LLM Katan servers..."
135119
@echo "⚠️ Note: Make sure LLM Katan servers are running with 'make start-llm-katan'"
136120
@python3 e2e-tests/run_all_tests.py
137121

138-
# Legacy: Run e2e tests with mock vLLM (assumes mock servers already running)
139-
test-e2e-mock:
140-
@echo "Running e2e tests with mock vLLM servers..."
141-
@echo "⚠️ Note: Make sure mock servers are running with 'make start-mock-vllm'"
142-
@python3 e2e-tests/run_all_tests.py --mock
143-
144-
# Run e2e tests with real vLLM (assumes real servers already running)
145-
test-e2e-real:
146-
@echo "Running e2e tests with real vLLM servers..."
147-
@echo "⚠️ Note: Make sure real vLLM servers are running with 'make start-vllm'"
148-
@python3 e2e-tests/run_all_tests.py --real
149-
150-
151-
# Note: Automated tests not supported with foreground-only mock servers
152-
# Use the manual workflow: make start-llm-katan in one terminal, then run tests in another
153-
154-
# Full automated test with cleanup (for CI/CD)
155-
test-e2e-real-automated: start-vllm
156-
@echo "Running automated e2e tests with real vLLM servers..."
157-
@sleep 5
158-
@python3 e2e-tests/run_all_tests.py --real || ($(MAKE) stop-vllm && exit 1)
159-
@$(MAKE) stop-vllm
160-
161-
# Run all e2e tests (LLM Katan, mock and real)
162-
test-e2e-all: test-e2e-vllm test-e2e-mock test-e2e-real
122+
# Note: Use the manual workflow: make start-llm-katan in one terminal, then run tests in another

0 commit comments

Comments
 (0)