Skip to content

Commit 969a99b

Browse files
committed
add default feature in generate support matrices (#1026)
Signed-off-by: Teresa Chen <boe20211@gmail.com>
1 parent 107d5f7 commit 969a99b

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

.buildkite/scripts/generate_support_matrices.sh

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,32 +44,33 @@ process_models() {
4444
}
4545

4646
process_features() {
47-
local feature row stage result
4847
declare -A feature_rows
4948

50-
# Process default features
5149
for feature in "${default_feature_list[@]:-}"; do
5250
if [[ -z "$feature" ]]; then continue; fi
53-
row="\"$feature\""
51+
local row="\"$feature\""
5452
for stage in "${FEATURE_STAGES[@]}"; do
55-
result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "")
53+
local result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "")
5654
row="$row,$result"
57-
check_failure "$result"
55+
if [ "${result}" != "" ] && [ "${result}" != "N/A" ] ; then
56+
ANY_FAILED=true
57+
fi
5858
done
5959
feature_rows["$feature"]="$row"
6060
done
6161

62-
# Process new/metadata features
6362
for feature in "${metadata_feature_list[@]:-}"; do
6463
if [[ -z "$feature" ]]; then continue; fi
6564
if [[ -v feature_rows["$feature"] ]]; then
6665
continue
6766
fi
68-
row="\"$feature\""
67+
local row="\"$feature\""
6968
for stage in "${FEATURE_STAGES[@]}"; do
70-
result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "N/A")
69+
local result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "N/A")
7170
row="$row,$result"
72-
check_failure "$result"
71+
if [ "${result}" != "" ] && [ "${result}" != "N/A" ] ; then
72+
ANY_FAILED=true
73+
fi
7374
done
7475
feature_rows["$feature"]="$row"
7576
done

0 commit comments

Comments
 (0)