Skip to content

Commit aae1f5b

Browse files
committed
add default feature in generate support matrices
Signed-off-by: Teresa Chen <boe20211@gmail.com>
1 parent cfc3ff8 commit aae1f5b

8 files changed

+78
-204
lines changed

.buildkite/features/Chunked_Prefill.yml

Lines changed: 0 additions & 40 deletions
This file was deleted.

.buildkite/features/JAX-Path_Qxix_Quantization.yml

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
11
# JAX-Path Qxix Quantization
22
steps:
3-
- label: "Correctness tests for JAX-Path Qxix Quantization"
4-
key: "JAX-Path_Qxix_Quantization_CorrectnessTest"
5-
soft_fail: true
6-
agents:
7-
queue: tpu_v6e_queue
8-
commands:
9-
- echo "covered by performance tests"
10-
- label: "Record correctness test result for JAX-Path Qxix Quantization"
11-
key: "record_JAX-Path_Qxix_Quantization_CorrectnessTest"
12-
depends_on: "JAX-Path_Qxix_Quantization_CorrectnessTest"
13-
env:
14-
CI_TARGET: "JAX-Path Qxix Quantization"
15-
CI_STAGE: "CorrectnessTest"
16-
agents:
17-
queue: cpu
18-
commands:
19-
- |
20-
.buildkite/scripts/record_step_result.sh JAX-Path_Qxix_Quantization_CorrectnessTest
3+
# - label: "Correctness tests for JAX-Path Qxix Quantization"
4+
# key: "JAX-Path_Qxix_Quantization_CorrectnessTest"
5+
# soft_fail: true
6+
# agents:
7+
# queue: tpu_v6e_queue
8+
# commands:
9+
# - echo "covered by performance tests"
10+
# - label: "Record correctness test result for JAX-Path Qxix Quantization"
11+
# key: "record_JAX-Path_Qxix_Quantization_CorrectnessTest"
12+
# depends_on: "JAX-Path_Qxix_Quantization_CorrectnessTest"
13+
# env:
14+
# CI_TARGET: "JAX-Path Qxix Quantization"
15+
# CI_STAGE: "CorrectnessTest"
16+
# agents:
17+
# queue: cpu
18+
# commands:
19+
# - |
20+
# .buildkite/scripts/record_step_result.sh JAX-Path_Qxix_Quantization_CorrectnessTest
2121

2222
- label: "Performance tests for JAX-Path Qxix Quantization"
2323
key: "JAX-Path_Qxix_Quantization_PerformanceTest"
24-
depends_on: "record_JAX-Path_Qxix_Quantization_CorrectnessTest"
24+
# depends_on: "record_JAX-Path_Qxix_Quantization_CorrectnessTest"
2525
soft_fail: true
2626
env:
2727
QUANTIZATION: "True"

.buildkite/features/Prefix_Caching.yml

Lines changed: 0 additions & 40 deletions
This file was deleted.

.buildkite/features/Quantized_Matmul_Attention_and_KV_Cache.yml

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
11
# Quantized Matmul Attention and KV Cache
22
steps:
3-
- label: "Correctness tests for Quantized Matmul Attention and KV Cache"
4-
key: "Quantized_Matmul_Attention_and_KV_Cache_CorrectnessTest"
5-
soft_fail: true
6-
agents:
7-
queue: cpu
8-
commands:
9-
- echo "covered by performance test"
10-
- label: "Record correctness test result for Quantized Matmul Attention and KV Cache"
11-
key: "record_Quantized_Matmul_Attention_and_KV_Cache_CorrectnessTest"
12-
depends_on: "Quantized_Matmul_Attention_and_KV_Cache_CorrectnessTest"
13-
env:
14-
CI_TARGET: "Quantized Matmul Attention and KV Cache"
15-
CI_STAGE: "CorrectnessTest"
16-
agents:
17-
queue: cpu
18-
commands:
19-
- |
20-
.buildkite/scripts/record_step_result.sh Quantized_Matmul_Attention_and_KV_Cache_CorrectnessTest
3+
# - label: "Correctness tests for Quantized Matmul Attention and KV Cache"
4+
# key: "Quantized_Matmul_Attention_and_KV_Cache_CorrectnessTest"
5+
# soft_fail: true
6+
# agents:
7+
# queue: cpu
8+
# commands:
9+
# - echo "covered by performance test"
10+
# - label: "Record correctness test result for Quantized Matmul Attention and KV Cache"
11+
# key: "record_Quantized_Matmul_Attention_and_KV_Cache_CorrectnessTest"
12+
# depends_on: "Quantized_Matmul_Attention_and_KV_Cache_CorrectnessTest"
13+
# env:
14+
# CI_TARGET: "Quantized Matmul Attention and KV Cache"
15+
# CI_STAGE: "CorrectnessTest"
16+
# agents:
17+
# queue: cpu
18+
# commands:
19+
# - |
20+
# .buildkite/scripts/record_step_result.sh Quantized_Matmul_Attention_and_KV_Cache_CorrectnessTest
2121

2222
- label: "Performance tests for Quantized Matmul Attention and KV Cache"
2323
key: "Quantized_Matmul_Attention_and_KV_Cache_PerformanceTest"
24-
depends_on: "record_Quantized_Matmul_Attention_and_KV_Cache_CorrectnessTest"
24+
# depends_on: "record_Quantized_Matmul_Attention_and_KV_Cache_CorrectnessTest"
2525
soft_fail: true
2626
agents:
2727
queue: tpu_v6e_8_queue

.buildkite/features/Ragged_Paged_Attention_V3.yml

Lines changed: 0 additions & 40 deletions
This file was deleted.

.buildkite/features/Single_Program_Multi_Data.yml

Lines changed: 0 additions & 40 deletions
This file was deleted.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Chunked Prefill
2+
Prefix Caching
3+
Ragged Paged Attention V3
4+
Single Program Multi Data

.buildkite/scripts/generate_support_matrices.sh

Lines changed: 36 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@ ANY_FAILED=false
55

66
MODEL_LIST_KEY="model-list"
77
FEATURE_LIST_KEY="feature-list"
8+
DEFAULT_FEATURES_FILE=".buildkite/features/default_features.txt"
89

910
# Note: This script assumes the metadata keys contain newline-separated lists.
1011
# The `mapfile` command reads these lists into arrays, correctly handling spaces.
1112
mapfile -t model_list < <(buildkite-agent meta-data get "${MODEL_LIST_KEY}" --default "")
12-
mapfile -t feature_list < <(buildkite-agent meta-data get "${FEATURE_LIST_KEY}" --default "")
13+
mapfile -t metadata_feature_list < <(buildkite-agent meta-data get "${FEATURE_LIST_KEY}" --default "")
1314
MODEL_STAGES=("UnitTest" "IntegrationTest" "Benchmark")
1415
FEATURE_STAGES=("CorrectnessTest" "PerformanceTest")
1516

@@ -20,8 +21,24 @@ echo "Model,UnitTest,IntegrationTest,Benchmark" > "$model_support_matrix_csv"
2021
feature_support_matrix_csv="feature_support_matrix.csv"
2122
echo "Feature,CorrectnessTest,PerformanceTest" > "$feature_support_matrix_csv"
2223

24+
# Read the list of default features from the specified file
25+
if [[ -f "${DEFAULT_FEATURES_FILE}" ]]; then
26+
mapfile -t default_feature_list < <(sed 's/\r$//; /^$/d' "${DEFAULT_FEATURES_FILE}")
27+
else
28+
default_feature_list=()
29+
echo "Warning: Default features file not found at ${DEFAULT_FEATURES_FILE}"
30+
fi
31+
32+
# Combine metadata features and default features into the final unique list
33+
mapfile -t feature_list < <(
34+
(
35+
printf "%s\n" "${metadata_feature_list[@]:-}"
36+
printf "%s\n" "${default_feature_list[@]:-}"
37+
) | sort -u | sed '/^$/d'
38+
)
39+
2340
process_models() {
24-
for model in "$@"; do
41+
for model in "${model_list[@]:-}"; do
2542
row="\"$model\""
2643
for stage in "${MODEL_STAGES[@]}"; do
2744
result=$(buildkite-agent meta-data get "${model}:${stage}" --default "N/A")
@@ -35,10 +52,23 @@ process_models() {
3552
}
3653

3754
process_features() {
38-
for feature in "$@"; do
55+
for feature in "${feature_list[@]:-}"; do
3956
row="\"$feature\""
57+
# Check if the current feature is in the default_feature_list
58+
is_default_feature=false
59+
for default_feat in "${default_feature_list[@]:-}"; do
60+
if [[ "${feature}" == "${default_feat}" ]]; then
61+
is_default_feature=true
62+
break
63+
fi
64+
done
4065
for stage in "${FEATURE_STAGES[@]}"; do
41-
result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "N/A")
66+
# Set the default value based on whether it's a default feature
67+
local default_value="N/A"
68+
if [ "$is_default_feature" = true ]; then
69+
default_value=""
70+
fi
71+
result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "${default_value}")
4272
row="$row,$result"
4373
if [ "${result}" != "" ] && [ "${result}" != "N/A" ] ; then
4474
ANY_FAILED=true
@@ -49,11 +79,11 @@ process_features() {
4979
}
5080

5181
if [ ${#model_list[@]} -gt 0 ]; then
52-
process_models "${model_list[@]}"
82+
process_models
5383
fi
5484

5585
if [ ${#feature_list[@]} -gt 0 ]; then
56-
process_features "${feature_list[@]}"
86+
process_features
5787
fi
5888

5989
buildkite-agent meta-data set "CI_TESTS_FAILED" "${ANY_FAILED}"

0 commit comments

Comments
 (0)