add default feature in generate support matrices (#1026)

Signed-off-by: Teresa Chen <boe20211@gmail.com>

Author: boe20211

.buildkite/scripts/generate_support_matrices.sh

@@ -29,14 +29,6 @@ else
     echo "Warning: Default features file not found at ${DEFAULT_FEATURES_FILE}"
 fi
 
-# Combine metadata features and default features into the final unique list
-mapfile -t feature_list < <(
-    (
-        printf "%s\n" "${metadata_feature_list[@]:-}"
-        printf "%s\n" "${default_feature_list[@]:-}"
-    ) | sort -u | sed '/^$/d'
-)
-
 process_models() {
     for model in "${model_list[@]:-}"; do
         row="\"$model\""
@@ -52,37 +44,46 @@ process_models() {
 }
 
 process_features() {
-    for feature in "${feature_list[@]:-}"; do
+    local feature row stage result
+    declare -A feature_rows
+
+    # Process default features
+    for feature in "${default_feature_list[@]:-}"; do
+        if [[ -z "$feature" ]]; then continue; fi
         row="\"$feature\""
-        # Check if the current feature is in the default_feature_list
-        is_default_feature=false
-        for default_feat in "${default_feature_list[@]:-}"; do
-            if [[ "${feature}" == "${default_feat}" ]]; then
-                is_default_feature=true
-                break
-            fi
+        for stage in "${FEATURE_STAGES[@]}"; do
+            result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "✅")
+            row="$row,$result"
+            check_failure "$result"
         done
+        feature_rows["$feature"]="$row"
+    done
+
+    # Process new/metadata features
+    for feature in "${metadata_feature_list[@]:-}"; do
+        if [[ -z "$feature" ]]; then continue; fi
+        if [[ -v feature_rows["$feature"] ]]; then
+            continue
+        fi
+        row="\"$feature\""
         for stage in "${FEATURE_STAGES[@]}"; do
-            # Set the default value based on whether it's a default feature
-            local default_value="N/A"
-            if [ "$is_default_feature" = true ]; then
-                default_value="✅"
-            fi
-            result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "${default_value}")
+            result=$(buildkite-agent meta-data get "${feature}:${stage}" --default "N/A")
             row="$row,$result"
-            if [ "${result}" != "✅" ] && [ "${result}" != "N/A" ] ; then
-                ANY_FAILED=true
-            fi
+            check_failure "$result"
         done
-        echo "$row" >> "$feature_support_matrix_csv"
+        feature_rows["$feature"]="$row"
     done
+
+    for row in "${feature_rows[@]}"; do
+        echo "$row"
+    done | sort -V >> "$feature_support_matrix_csv"
 }
 
 if [ ${#model_list[@]} -gt 0 ]; then
     process_models
 fi
 
-if [ ${#feature_list[@]} -gt 0 ]; then
+if [ ${#metadata_feature_list[@]} -gt 0 ] || [ ${#default_feature_list[@]} -gt 0 ]; then
     process_features
 fi