-
Notifications
You must be signed in to change notification settings - Fork 77
enable lmcache #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hsubramony
wants to merge
11
commits into
vllm-project:main
Choose a base branch
from
hsubramony:lmcache_main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
enable lmcache #521
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b12882a
enable lmcache with latest vllm and lmcache
hsubramony 48ff5f6
Add test scripts for lmcache
hsubramony ccc8e78
add lmcacheconnector to hpu_model_runner
libinta 529fcad
Merge branch 'main' into lmcache_main
michalkuligowski a9ff78e
Merge remote-tracking branch 'origin/main' into lmcache_main
hsubramony eba6ca4
enable store / retrieve through lmcache
hsubramony 8153be6
Merge remote-tracking branch 'origin/main' into lmcache_main
hsubramony 2341c32
Fix lmcache test scripts and readme
hsubramony 961ba12
pre-commit fixes
hsubramony b6d697f
Merge branch 'origin/main'
hsubramony d32163f
minor fixes
hsubramony File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is default value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i believe default was 1 , we were having issues running tp>1 so it needed to be explicitly set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this is weird issue, can you send a PR to upstream to fix that?
I am ok with fix here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they do set it for tpu_worker but not for gpu or xpu
https://github.com/vllm-project/vllm/blob/ad32e3e19ccf0526cb6744a5fed09a138a5fb2f9/vllm/v1/worker/tpu_worker.py#L79