[+]: "PHPParameter" -> catch UnableToCompileNode Exceptions

Author: voku

src/voku/SimplePhpParser/Model/PHPParameter.php

@@ -134,8 +134,11 @@ public function readObjectFromBetterReflection($parameter): self
         $this->name = $parameter->getName();
 
         if ($parameter->isDefaultValueAvailable()) {
-            $this->defaultValue = $parameter->getDefaultValue();
-
+            try {
+                $this->defaultValue = $parameter->getDefaultValue();
+            } catch (\Roave\BetterReflection\NodeCompiler\Exception\UnableToCompileNode $e) {
+                // nothing
+            }
             if ($this->defaultValue !== null) {
                 $this->typeFromDefaultValue = Utils::normalizePhpType(\gettype($this->defaultValue));
             }
@@ -152,7 +155,11 @@ public function readObjectFromBetterReflection($parameter): self
             $this->readPhpDoc($docComment, $this->name);
         }
 
-        $type = $parameter->getType();
+        try {
+            $type = $parameter->getType();
+        } catch (\Roave\BetterReflection\NodeCompiler\Exception\UnableToCompileNode $e) {
+            $type = null;
+        }
         if ($type !== null) {
             if (\method_exists($type, 'getName')) {
                 $this->type = Utils::normalizePhpType($type->getName());

src/voku/SimplePhpParser/Parsers/Helper/Utils.php

@@ -159,7 +159,9 @@ public static function getPhpParserValueFromNode(
                 return null;
             }
 
-            return $node->name->parts[0];
+            if (\defined($node->name->parts[0])) {
+                return \constant($node->name->parts[0]);
+            }
         }
 
         return self::GET_PHP_PARSER_VALUE_FROM_NODE_HELPER;

tests/CheckerTest.php

@@ -20,16 +20,16 @@ public function testCheckPhpClasses(): void
         static::assertSame(
             [
                 'Simple-PHP-Code-Parser/tests/Dummy3.php' => [
-                    0 => '[7]: missing return type for voku\tests\foo3()',
-                    1 => '[15]: missing property type for voku\tests\Dummy3->$foo',
-                    2 => '[15]: missing property type for voku\tests\Dummy3->$foo_mixed',
-                    3 => '[150]: missing parameter type "null" in phpdoc from voku\tests\Dummy3->lall8() | parameter:case',
-                    4 => '[40]: missing parameter type for voku\tests\Dummy3->lall() | parameter:foo',
-                    5 => '[40]: missing return type for voku\tests\Dummy3->lall()',
-                    6 => '[70]: wrong return type "string" in phpdoc from voku\tests\Dummy3->lall3()',
-                    7 => '[60]: wrong return type "null" in phpdoc from voku\tests\Dummy3->lall2_1()',
-                    8 => '[50]: missing return type "null" in phpdoc from voku\tests\Dummy3->lall2()',
-                    9 => '[80]: wrong parameter type "string" in phpdoc from voku\tests\Dummy3->lall3_1()  | parameter:foo',
+                    0 => '[9]: missing return type for voku\tests\foo3()',
+                    1 => '[19]: missing property type for voku\tests\Dummy3->$foo',
+                    2 => '[19]: missing property type for voku\tests\Dummy3->$foo_mixed',
+                    3 => '[154]: missing parameter type "null" in phpdoc from voku\tests\Dummy3->lall8() | parameter:case',
+                    4 => '[44]: missing parameter type for voku\tests\Dummy3->lall() | parameter:foo',
+                    5 => '[44]: missing return type for voku\tests\Dummy3->lall()',
+                    6 => '[74]: wrong return type "string" in phpdoc from voku\tests\Dummy3->lall3()',
+                    7 => '[64]: wrong return type "null" in phpdoc from voku\tests\Dummy3->lall2_1()',
+                    8 => '[54]: missing return type "null" in phpdoc from voku\tests\Dummy3->lall2()',
+                    9 => '[84]: wrong parameter type "string" in phpdoc from voku\tests\Dummy3->lall3_1()  | parameter:foo',
                 ],
             ],
             $phpCodeErrors

tests/Dummy3.php

@@ -4,11 +4,15 @@
 
 namespace voku\tests;
 
+use const SORT_ASC as SORT_ASC_TEST;
+
 function foo3(int $foo = 0)
 {
     return new Dummy();
 }
 
+const SORT_ASC_TEST_2 = SORT_ASC;
+
 /**
  * @internal
  */
@@ -162,6 +166,26 @@ public function lall9(int $case = self::CASE_NULL): DummyInterface
         return new self;
     }
 
+    /**
+     * @param int $case
+     *
+     * @return \voku\tests\Dummy3
+     */
+    public function lall10(int $case = SORT_ASC_TEST): DummyInterface
+    {
+        return new self;
+    }
+
+    /**
+     * @param int $case
+     *
+     * @return \voku\tests\Dummy3
+     */
+    public function lall11(int $case = SORT_ASC_TEST_2): DummyInterface
+    {
+        return new self;
+    }
+
     /**
      * This is a test-text [...] öäü !"§?.
      *