Safe AVX FDCT #18
Merged
Safe AVX FDCT #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fe fn' from it now that it contains no unsafe ops
This was referenced Oct 30, 2025
Stores into fixed-size slices are easy to misuse, lead to subtle bugs
okaneco/safe_unaligned_simd#33
Closed
Owner
|
No performance changes on Zen3 and Haswell as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to #17, requires Rust 1.86 or later.
Unlike #17 the conversion here is really straightforward. The function was already performing all the necessary safety checks without relying on the caller to uphold any invariants before this PR.
No change on the Criterion benchmarks in the repo on my Zen4 CPU.