chore: code review from Alex

Author: hunterliu1003

packages/vue-final-modal/src/components/VueFinalModal/VueFinalModal.vue

@@ -159,9 +159,9 @@ async function openLastOverlay() {
   })
 }
 
-const modalId = toRef(props, 'modalId')
-const hideOverlay = toRef(props, 'hideOverlay')
-const overlayBehavior = toRef(props, 'overlayBehavior')
+const modalId = toRef(() => props.modalId)
+const hideOverlay = toRef(() => props.hideOverlay)
+const overlayBehavior = toRef(() => props.overlayBehavior)
 const modalExposed = computed<ModalExposed>(() => ({
   modalId,
   hideOverlay,

packages/vue-final-modal/src/components/VueFinalModal/VueFinalModalProps.ts

@@ -2,9 +2,11 @@ import type { Options } from 'focus-trap'
 import type { PropType, RendererElement, TransitionProps } from 'vue'
 import type { ModalId, StyleValue } from '~/Modal'
 
-// Hack from: https://github.com/microsoft/TypeScript/issues/29729#issuecomment-1331857805
-type AnyString = string & {}
-type VfmTransition = 'vfm-fade' | 'vfm-slide-down' | 'vfm-slide-up' | 'vfm-slide-right' | 'vfm-slide-left' | AnyString
+/**
+ * @see [Microsoft/TypeScript#29729](https://github.com/Microsoft/TypeScript/issues/29729)
+ */
+type LiteralUnion<T extends U, U = string> = T | (U & Record<never, never>)
+type VfmTransition = LiteralUnion<'vfm-fade' | 'vfm-slide-down' | 'vfm-slide-up' | 'vfm-slide-right' | 'vfm-slide-left'>
 
 export const vueFinalModalProps = {
   /**

packages/vue-final-modal/src/plugin.ts

@@ -59,9 +59,14 @@ export function createVfm() {
     },
     closeAll() {
       return Promise.allSettled(openedModals
-        .map(modal => getModalExposed(modal))
-        .filter((modal): modal is ComputedRef<ModalExposed> => !!modal)
-        .map(modal => modal.value.toggle(false)))
+        .reduce<Promise<string>[]>((acc, cur) => {
+          const modalExposed = getModalExposed(cur)
+          const promise = modalExposed?.value.toggle(false)
+          if (promise)
+            acc.push(promise)
+          return acc
+        }, []),
+      )
     },
   })
 
@@ -70,6 +75,6 @@ export function createVfm() {
   return vfm
 }
 
-export function getModalExposed(componentInternalInstance: undefined | null | ComponentInternalInstance): null | ComputedRef<ModalExposed> {
-  return componentInternalInstance?.exposed?.modalExposed || null
+export function getModalExposed(componentInternalInstance: undefined | null | ComponentInternalInstance): undefined | null | ComputedRef<ModalExposed> {
+  return componentInternalInstance?.exposed?.modalExposed
 }