fix(matcher): addRoutes navigate to same as current location (#3228)

Checking for the length is not enough when having a path: '*' route
Closes #3216

Author: posva

src/history/base.js

@@ -137,10 +137,13 @@ export class History {
       }
       onAbort && onAbort(err)
     }
+    const lastRouteIndex = route.matched.length - 1
+    const lastCurrentIndex = current.matched.length - 1
     if (
       isSameRoute(route, current) &&
       // in the case the route map has been dynamically appended to
-      route.matched.length === current.matched.length
+      lastRouteIndex === lastCurrentIndex &&
+      route.matched[lastRouteIndex] === current.matched[lastCurrentIndex]
     ) {
       this.ensureURL()
       return abort(createNavigationDuplicatedError(current, route))

test/unit/specs/api.spec.js

@@ -116,6 +116,23 @@ describe('router.addRoutes', () => {
     expect(components.length).toBe(1)
     expect(components[0].name).toBe('A')
   })
+
+  it('allows navigating to the same as current location', () => {
+    const router = new Router({
+      routes: [
+        { path: '/', component: {}},
+        { path: '*', component: {}}
+      ]
+    })
+
+    router.push('/not-found')
+
+    expect(router.currentRoute.params).toEqual({ pathMatch: '/not-found' })
+    router.addRoutes([{ path: '/not-found', component: {}}])
+
+    // the navigation should have changed locations
+    expect(router.currentRoute.params).toEqual({})
+  })
 })
 
 describe('router.push/replace', () => {