fix(fileSize): ensure consistency of output order (#6689)

Author: chenjiahan

e2e/cases/print-file-size/basic/index.test.ts

@@ -71,17 +71,17 @@ dist/static/js/lib-react.[[hash]].js   X.X kB   X.X kB
     });
 
     expect(extractFileSizeLogs(rsbuild.logs)).toEqual(`
-File (node)                         Size
-dist/server/static/image/icon.png   X.X kB
-dist/server/index.js                X.X kB
-                           Total:   X.X kB
 File (web)                    Size       Gzip
 dist/static/css/index.css     X.X kB    X.X kB
 dist/index.html               X.X kB    X.X kB
 dist/static/js/index.js       X.X kB     X.X kB
 dist/static/image/icon.png    X.X kB
 dist/static/js/lib-react.js   X.X kB   X.X kB
-                     Total:   X.X kB   X.X kB`);
+                     Total:   X.X kB   X.X kB
+File (node)                         Size
+dist/server/static/image/icon.png   X.X kB
+dist/server/index.js                X.X kB
+                           Total:   X.X kB`);
   });
 
   test('should not print logs when printFileSize is false', async ({

packages/core/src/plugins/fileSize.ts

@@ -406,14 +406,19 @@ export const pluginFileSize = (context: InternalContext): RsbuildPlugin => ({
         return;
       }
 
+      const environments = context.environmentList.filter(
+        ({ config }) => config.performance.printFileSize !== false,
+      );
+
+      // If no environment has printFileSize enabled, skip
+      if (!environments.length) {
+        return;
+      }
+
       // Check if any environment has diff enabled
-      const showDiff = context.environmentList.some((environment) => {
+      const showDiff = environments.some((environment) => {
         const { printFileSize } = environment.config.performance;
-        if (typeof printFileSize === 'boolean') {
-          // uses default (false)
-          return false;
-        }
-        return Boolean(printFileSize.diff);
+        return typeof printFileSize === 'object' && Boolean(printFileSize.diff);
       });
 
       // Load previous build sizes for comparison (only if diff is enabled)
@@ -422,22 +427,15 @@ export const pluginFileSize = (context: InternalContext): RsbuildPlugin => ({
         : {};
       const newCache: FileSizeCache = {};
 
-      const logs: string[] = [];
-
-      await Promise.all(
-        context.environmentList.map(async (environment, index) => {
-          const { printFileSize } = environment.config.performance;
-
-          if (printFileSize === false) {
-            return;
-          }
-
+      const logs = await Promise.all(
+        environments.map(async ({ name, index, config, distPath }) => {
+          const { printFileSize } = config.performance;
           const defaultConfig: PrintFileSizeOptions = {
             total: true,
             detail: true,
             diff: false,
             // print compressed size for the browser targets by default
-            compressed: environment.config.output.target !== 'node',
+            compressed: config.output.target !== 'node',
           };
 
           const mergedConfig =
@@ -453,24 +451,26 @@ export const pluginFileSize = (context: InternalContext): RsbuildPlugin => ({
             mergedConfig,
             statsItem,
             api.context.rootPath,
-            environment.distPath,
-            environment.name,
+            distPath,
+            name,
             previousSizes,
           );
 
-          logs.push(...statsLogs);
-
           // Store current sizes for this environment
-          newCache[environment.name] = currentSizes;
+          newCache[name] = currentSizes;
+
+          return statsLogs.join('\n');
         }),
       ).catch((err: unknown) => {
         logger.warn('Failed to print file size.');
         logger.warn(err);
       });
 
-      logger.log(logs.join('\n'));
+      if (logs) {
+        logger.log(logs.join('\n'));
+      }
 
-      // Save current sizes for next build comparison (only if showDiff is enabled)
+      // Save current sizes for next build comparison (only if diff is enabled)
       if (showDiff) {
         await saveSizes(api.context.cachePath, newCache);
       }