Skip to content

Commit f14c75d

Browse files
HannaTarasevichHanna Tarasevich
andauthored
[v6] Fix platform/device determination (#610)
* Fix dependency * Fix 582 issue * Fix 582 issue * Fix 582 issue * Fix 582 issue * Fix 582 issue * Fix 582 issue * Fix 582 issue * Upgrade eslint packages * Update dependencies * Fix 582 issue * Resolve comments * Resolve comments * Change ConfigCapabilities to DesiredCapabilitiesExtended * Resolve comments * Resolve comments * Resolve issue (device/platform info) --------- Co-authored-by: Hanna Tarasevich <htarasevich@deloitte.com>
1 parent f034742 commit f14c75d

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

src/metadata.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ export class Metadata {
2323
// Fixes: https://github.com/webdriverio-community/wdio-cucumberjs-json-reporter/issues/73
2424
? data.capabilities['cjson:metadata'] as cjson_metadata
2525
// Fallback
26-
: (browser as WebdriverIOExtended)?.requestedCapabilities?.cjson_metadata
26+
: (browser as WebdriverIOExtended)?.requestedCapabilities?.['cjson:metadata'] as cjson_metadata
2727
: {}
28-
const metadata: cjson_metadata = (currentConfigCapabilities as W3CCapabilitiesExtended)?.cjson_metadata
28+
const metadata: cjson_metadata = (currentConfigCapabilities as W3CCapabilitiesExtended)?.['cjson:metadata']
2929
|| w3cCaps // When an app is used to test
30-
|| (optsCaps as DesiredCapabilitiesExtended)?.cjson_metadata // devtools
30+
|| (optsCaps as DesiredCapabilitiesExtended)?.['cjson:metadata'] // devtools
3131
|| {} as cjson_metadata
3232

3333
// When an app is used to test

src/types/wdio.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,27 +13,27 @@ import type { cjson_metadata } from '../types'
1313
import { W3CCapabilities } from '@wdio/types/build/Capabilities'
1414

1515
export interface W3CCapabilitiesExtended extends W3CCapabilities {
16-
cjson_metadata?: cjson_metadata
16+
'cjson:metadata'?: cjson_metadata
1717
app?: string
1818
}
1919

2020
export interface DesiredCapabilitiesExtended extends WebdriverIO.Capabilities {
21-
cjson_metadata?: cjson_metadata
21+
'cjson:metadata'?: cjson_metadata
2222
app?: string
2323
}
2424

2525
export interface TestrunnerExtended extends Options.Testrunner {
2626
jsonFolder?: string
2727
language?: string
28-
cjson_metadata?: cjson_metadata
28+
'cjson:metadata'?: cjson_metadata
2929
logFile?: string
3030
stdout?: boolean
3131
writeStream?: WriteStream
3232
}
3333
export interface WebdriverIOExtended extends Options.WebdriverIO {
3434
app?: string
3535
requestedCapabilities?: {
36-
cjson_metadata?: cjson_metadata
36+
'cjson:metadata'?: cjson_metadata
3737
w3cCaps: {
3838
alwaysMatch?: {
3939
foo?: true

tests/__mocks__/mocks.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export const FULL_RUNNER_STATS: RunnerStatsExtended = {
6060
cid: '0-0',
6161
capabilities:
6262
<DesiredCapabilitiesExtended>{
63-
cjson_metadata: {} as cjson_metadata,
63+
'cjson:metadata': {} as cjson_metadata,
6464
acceptInsecureCerts: false,
6565
acceptSslCerts: false,
6666
applicationCacheEnabled: false,
@@ -154,7 +154,7 @@ export const FULL_RUNNER_STATS: RunnerStatsExtended = {
154154
capabilities: {},
155155
jsonFolder: '',
156156
language: 'en',
157-
cjson_metadata: {
157+
'cjson:metadata': {
158158
app: {
159159
name: 'test',
160160
version: '1'
@@ -196,7 +196,7 @@ export const WDIO6_RUNNER_STATS: RunnerStatsExtended = {
196196
config: <TestrunnerExtended>{
197197
jsonFolder: '',
198198
language: 'en',
199-
cjson_metadata: {} as cjson_metadata,
199+
'cjson:metadata': {} as cjson_metadata,
200200
logFile: '',
201201
stdout: true,
202202
writeStream: {} as WriteStream,

tests/metadata.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ describe('metadata', () => {
259259

260260
it('should return app metadata based on the current.config.capabilities[\'cjson:metadata\'].app', () => {
261261
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
262-
(FULL_RUNNER_STATS.capabilities as W3CCapabilitiesExtended).cjson_metadata!.app = {
262+
(FULL_RUNNER_STATS.capabilities as W3CCapabilitiesExtended)['cjson:metadata']!.app = {
263263
name: 'mock-appName',
264264
version: 'mock-appVersion',
265265
}
@@ -274,7 +274,7 @@ describe('metadata', () => {
274274
expect(determinePlatformVersionSpy).toHaveBeenCalledTimes(1)
275275

276276
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
277-
delete (FULL_RUNNER_STATS.capabilities as W3CCapabilitiesExtended).cjson_metadata!.app
277+
delete (FULL_RUNNER_STATS.capabilities as W3CCapabilitiesExtended)['cjson:metadata']!.app
278278
determineAppDataSpy.mockClear()
279279
})
280280

@@ -300,7 +300,7 @@ describe('metadata', () => {
300300
requestedCapabilities: {
301301
w3cCaps: {
302302
alwaysMatch: {
303-
cjson_metadata: {},
303+
'cjson:metadata': {},
304304
},
305305
},
306306
},
@@ -323,7 +323,7 @@ describe('metadata', () => {
323323
},
324324
capabilities: {
325325
browserName: 'chrome',
326-
cjson_metadata: {},
326+
'cjson:metadata': {},
327327
},
328328
} as WebdriverIOExtended,
329329
}
@@ -341,7 +341,7 @@ describe('metadata', () => {
341341
options: {
342342
capabilities: {
343343
browserName: 'chrome',
344-
cjson_metadata: {},
344+
'cjson:metadata': {},
345345
},
346346
} as WebdriverIOExtended,
347347
}

0 commit comments

Comments
 (0)