fix: compatibility with named export and es5 (#751)

alexander-akait · web-flow · commit 3be81bb4e795 · 2021-04-28T16:34:03.000+03:00
diff --git a/src/loader.js b/src/loader.js
@@ -155,7 +155,7 @@ export function pitch(request) {
       ? namedExport
         ? Object.keys(locals)
             .map(
-              (key) => `\nexport const ${key} = ${JSON.stringify(locals[key])};`
+              (key) => `\nexport var ${key} = ${JSON.stringify(locals[key])};`
             )
             .join('')
         : `\n${
diff --git a/test/cases/es-module-concatenation-modules/expected/webpack-4/main.js b/test/cases/es-module-concatenation-modules/expected/webpack-4/main.js
@@ -116,13 +116,13 @@ __webpack_require__.d(index_namespaceObject, "b", function() { return b_namespac
 
 // CONCATENATED MODULE: ./a.css
 // extracted by mini-css-extract-plugin
-const a = "foo__a";
+var a = "foo__a";
 // CONCATENATED MODULE: ./b.css
 // extracted by mini-css-extract-plugin
-const b = "foo__b";
+var b = "foo__b";
 // CONCATENATED MODULE: ./c.css
 // extracted by mini-css-extract-plugin
-const c = "foo__c";
+var c = "foo__c";
 // CONCATENATED MODULE: ./index.js
 /* eslint-disable import/no-namespace */
 
diff --git a/test/cases/es-module-concatenation-modules/expected/webpack-5-importModule/main.js b/test/cases/es-module-concatenation-modules/expected/webpack-5-importModule/main.js
@@ -69,13 +69,13 @@ __webpack_require__.d(index_namespaceObject, {
 
 ;// CONCATENATED MODULE: ./a.css
 // extracted by mini-css-extract-plugin
-const a = "foo__a";
+var a = "foo__a";
 ;// CONCATENATED MODULE: ./b.css
 // extracted by mini-css-extract-plugin
-const b = "foo__b";
+var b = "foo__b";
 ;// CONCATENATED MODULE: ./c.css
 // extracted by mini-css-extract-plugin
-const c = "foo__c";
+var c = "foo__c";
 ;// CONCATENATED MODULE: ./index.js
 /* eslint-disable import/no-namespace */
 
diff --git a/test/cases/es-module-concatenation-modules/expected/webpack-5/main.js b/test/cases/es-module-concatenation-modules/expected/webpack-5/main.js
@@ -69,13 +69,13 @@ __webpack_require__.d(index_namespaceObject, {
 
 ;// CONCATENATED MODULE: ./a.css
 // extracted by mini-css-extract-plugin
-const a = "foo__a";
+var a = "foo__a";
 ;// CONCATENATED MODULE: ./b.css
 // extracted by mini-css-extract-plugin
-const b = "foo__b";
+var b = "foo__b";
 ;// CONCATENATED MODULE: ./c.css
 // extracted by mini-css-extract-plugin
-const c = "foo__c";
+var c = "foo__c";
 ;// CONCATENATED MODULE: ./index.js
 /* eslint-disable import/no-namespace */
 
diff --git a/test/cases/es-named-export-output-module/expected/main.js b/test/cases/es-named-export-output-module/expected/main.js
@@ -11,9 +11,9 @@ __webpack_require__.r(__webpack_exports__);
 /* harmony export */   "cClass": () => (/* binding */ cClass)
 /* harmony export */ });
 // extracted by mini-css-extract-plugin
-const aClass = "foo__style__a-class";
-const bClass = "foo__style__b__class";
-const cClass = "foo__style__cClass";
+var aClass = "foo__style__a-class";
+var bClass = "foo__style__b__class";
+var cClass = "foo__style__cClass";
 
 /***/ })
 /******/ ]);
diff --git a/test/cases/es-named-export/expected/webpack-4/main.js b/test/cases/es-named-export/expected/webpack-4/main.js
@@ -107,9 +107,9 @@ __webpack_require__.r(__webpack_exports__);
 /* harmony export (binding) */ __webpack_require__.d(__webpack_exports__, "bClass", function() { return bClass; });
 /* harmony export (binding) */ __webpack_require__.d(__webpack_exports__, "cClass", function() { return cClass; });
 // extracted by mini-css-extract-plugin
-const aClass = "foo__style__a-class";
-const bClass = "foo__style__b__class";
-const cClass = "foo__style__cClass";
+var aClass = "foo__style__a-class";
+var bClass = "foo__style__b__class";
+var cClass = "foo__style__cClass";
 
 /***/ })
 /******/ ]);
diff --git a/test/cases/es-named-export/expected/webpack-5-importModule/main.js b/test/cases/es-named-export/expected/webpack-5-importModule/main.js
@@ -12,9 +12,9 @@ __webpack_require__.r(__webpack_exports__);
 /* harmony export */   "cClass": () => (/* binding */ cClass)
 /* harmony export */ });
 // extracted by mini-css-extract-plugin
-const aClass = "foo__style__a-class";
-const bClass = "foo__style__b__class";
-const cClass = "foo__style__cClass";
+var aClass = "foo__style__a-class";
+var bClass = "foo__style__b__class";
+var cClass = "foo__style__cClass";
 
 /***/ })
 /******/ 	]);
diff --git a/test/cases/es-named-export/expected/webpack-5/main.js b/test/cases/es-named-export/expected/webpack-5/main.js
@@ -12,9 +12,9 @@ __webpack_require__.r(__webpack_exports__);
 /* harmony export */   "cClass": () => (/* binding */ cClass)
 /* harmony export */ });
 // extracted by mini-css-extract-plugin
-const aClass = "foo__style__a-class";
-const bClass = "foo__style__b__class";
-const cClass = "foo__style__cClass";
+var aClass = "foo__style__a-class";
+var bClass = "foo__style__b__class";
+var cClass = "foo__style__cClass";
 
 /***/ })
 /******/ 	]);

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ export function pitch(request) {`
`155`	`155`	`? namedExport`
`156`	`156`	`? Object.keys(locals)`
`157`	`157`	`.map(`
`158`		- (key) => `\nexport const ${key} = ${JSON.stringify(locals[key])};`
	`158`	+ (key) => `\nexport var ${key} = ${JSON.stringify(locals[key])};`
`159`	`159`	`)`
`160`	`160`	`.join('')`
`161`	`161`	: `\n${