Skip to content

Commit e3f8375

Browse files
alexander-akaitalexander-akait
authored
fix: add ChunkLoadError name to chunk loading error (#1073)
1 parent 60c5331 commit e3f8375

File tree

11 files changed

+24
-16
lines changed

11 files changed

+24
-16
lines changed

‎src/index.js‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -876,9 +876,11 @@ class MiniCssExtractPlugin {
876876
Template.indent(["resolve();"]),
877877
"} else {",
878878
Template.indent([
879-
"var errorType = event && (event.type === 'load' ? 'missing' : event.type);",
879+
"var errorType = event && event.type;",
880880
"var realHref = event && event.target && event.target.href || fullhref;",
881-
'var err = new Error("Loading CSS chunk " + chunkId + " failed.\\n(" + realHref + ")");',
881+
'var err = new Error("Loading CSS chunk " + chunkId + " failed.\\n(" + errorType + ": " + realHref + ")");',
882+
'err.name = "ChunkLoadError";',
883+
// TODO remove `code` in the future major release to align with webpack
882884
'err.code = "CSS_CHUNK_LOAD_FAILED";',
883885
"err.type = errorType;",
884886
"err.request = realHref;",

‎test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.55be87a9aa9996fc905c.css‎ renamed to ‎test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/0.7f0e5fa686a9bb728e64.css‎

File renamed without changes.

‎test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/55be87a9aa9996fc905c.css‎ renamed to ‎test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/7f0e5fa686a9bb728e64.css‎

File renamed without changes.

‎test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__);
7373
/******/
7474
/******/ /* webpack/runtime/getFullHash */
7575
/******/ (() => {
76-
/******/ __webpack_require__.h = () => ("55be87a9aa9996fc905c")
76+
/******/ __webpack_require__.h = () => ("7f0e5fa686a9bb728e64")
7777
/******/ })();
7878
/******/
7979
/******/ /* webpack/runtime/global */
@@ -187,9 +187,10 @@ __webpack_require__.r(__webpack_exports__);
187187
/******/ if (event.type === 'load') {
188188
/******/ resolve();
189189
/******/ } else {
190-
/******/ var errorType = event && (event.type === 'load' ? 'missing' : event.type);
190+
/******/ var errorType = event && event.type;
191191
/******/ var realHref = event && event.target && event.target.href || fullhref;
192-
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + realHref + ")");
192+
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + errorType + ": " + realHref + ")");
193+
/******/ err.name = "ChunkLoadError";
193194
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
194195
/******/ err.type = errorType;
195196
/******/ err.request = realHref;

‎test/cases/chunkFilename-fullhash/expected/webpack-5/0.4a73d63c8c2357971fc6.css‎ renamed to ‎test/cases/chunkFilename-fullhash/expected/webpack-5/0.100253bb7576627988e6.css‎

File renamed without changes.

‎test/cases/chunkFilename-fullhash/expected/webpack-5/4a73d63c8c2357971fc6.css‎ renamed to ‎test/cases/chunkFilename-fullhash/expected/webpack-5/100253bb7576627988e6.css‎

File renamed without changes.

‎test/cases/chunkFilename-fullhash/expected/webpack-5/main.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__);
7373
/******/
7474
/******/ /* webpack/runtime/getFullHash */
7575
/******/ (() => {
76-
/******/ __webpack_require__.h = () => ("4a73d63c8c2357971fc6")
76+
/******/ __webpack_require__.h = () => ("100253bb7576627988e6")
7777
/******/ })();
7878
/******/
7979
/******/ /* webpack/runtime/global */
@@ -187,9 +187,10 @@ __webpack_require__.r(__webpack_exports__);
187187
/******/ if (event.type === 'load') {
188188
/******/ resolve();
189189
/******/ } else {
190-
/******/ var errorType = event && (event.type === 'load' ? 'missing' : event.type);
190+
/******/ var errorType = event && event.type;
191191
/******/ var realHref = event && event.target && event.target.href || fullhref;
192-
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + realHref + ")");
192+
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + errorType + ": " + realHref + ")");
193+
/******/ err.name = "ChunkLoadError";
193194
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
194195
/******/ err.type = errorType;
195196
/******/ err.request = realHref;

‎test/cases/hmr/expected/main.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -950,9 +950,10 @@ __webpack_require__.r(__webpack_exports__);
950950
/******/ if (event.type === 'load') {
951951
/******/ resolve();
952952
/******/ } else {
953-
/******/ var errorType = event && (event.type === 'load' ? 'missing' : event.type);
953+
/******/ var errorType = event && event.type;
954954
/******/ var realHref = event && event.target && event.target.href || fullhref;
955-
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + realHref + ")");
955+
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + errorType + ": " + realHref + ")");
956+
/******/ err.name = "ChunkLoadError";
956957
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
957958
/******/ err.type = errorType;
958959
/******/ err.request = realHref;

‎test/cases/insert-function/expected/main.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,10 @@
171171
/******/ if (event.type === 'load') {
172172
/******/ resolve();
173173
/******/ } else {
174-
/******/ var errorType = event && (event.type === 'load' ? 'missing' : event.type);
174+
/******/ var errorType = event && event.type;
175175
/******/ var realHref = event && event.target && event.target.href || fullhref;
176-
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + realHref + ")");
176+
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + errorType + ": " + realHref + ")");
177+
/******/ err.name = "ChunkLoadError";
177178
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
178179
/******/ err.type = errorType;
179180
/******/ err.request = realHref;

‎test/cases/insert-string/expected/main.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,10 @@
171171
/******/ if (event.type === 'load') {
172172
/******/ resolve();
173173
/******/ } else {
174-
/******/ var errorType = event && (event.type === 'load' ? 'missing' : event.type);
174+
/******/ var errorType = event && event.type;
175175
/******/ var realHref = event && event.target && event.target.href || fullhref;
176-
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + realHref + ")");
176+
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + errorType + ": " + realHref + ")");
177+
/******/ err.name = "ChunkLoadError";
177178
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
178179
/******/ err.type = errorType;
179180
/******/ err.request = realHref;

0 commit comments

Comments
 (0)