-
Notifications
You must be signed in to change notification settings - Fork 52
Open
Description
Review Draft publication goes relatively well (though see #348) as per https://github.com/whatwg/meta/blob/main/MAINTAINERS.md#review-drafts. One problem is recovering from build failures.
When hitting a build failure my current process is something like this:
- Create a separate PR to address the build failure.
- Rebase the RD PR.
- Change the
review.shscript by commenting out four lines (starting withgit checkout main) to avoid it creating a new branch. - Make
review.shexecutable viachmod 755 review.sh(755 is prolly too much?). - Run it.
- Rebase the RD PR again folding the new commit into the previous one.
- Force push.
- Hopefully all is well now.
Step 1 is always needed. Ideally step 2 through 7 would be replaced by a single step, e.g., ./review.sh redo.
Anyone else have thoughts on this?
Metadata
Metadata
Assignees
Labels
No labels