Add check for overwriting files

Author: wol-soft

.gitignore

@@ -1,5 +1,6 @@
 /docs/build/
 /tests/manual/result/
+/failed-classes/
 /vendor/
 .idea
 composer.lock

README.md

@@ -176,4 +176,4 @@ After installing the dependencies of the library via `composer update` you can e
 
 During the execution the tests will create a directory PHPModelGeneratorTest in tmp where JSON-Schema files and PHP classes will be written to.
 
-If a test which creates a PHP class from a JSON-Schema fails the JSON-Schema and the generated class(es) will be dumped to the directory `./Failed-classes`
+If a test which creates a PHP class from a JSON-Schema fails the JSON-Schema and the generated class(es) will be dumped to the directory `./failed-classes`

src/Model/RenderJob.php

@@ -53,9 +53,13 @@ public function render(string $destination, GeneratorConfiguration $generatorCon
 
         $class = $this->renderClass($generatorConfiguration);
 
+        if (file_exists($this->fileName)) {
+            throw new FileSystemException("File {$this->fileName} already exists. Make sure object IDs are unique.");
+        }
+
         if (!file_put_contents($this->fileName, $class)) {
             // @codeCoverageIgnoreStart
-            throw new FileSystemException("Can't write class $this->classPath\\$this->className");
+            throw new FileSystemException("Can't write class $this->classPath\\$this->className.");
             // @codeCoverageIgnoreEnd
         }
 

src/PropertyProcessor/ComposedValue/AbstractComposedValueProcessor.php

@@ -26,6 +26,8 @@
  */
 abstract class AbstractComposedValueProcessor extends AbstractValueProcessor
 {
+    private static $generatedMergedProperties = [];
+
     /**
      * @inheritdoc
      */
@@ -115,8 +117,14 @@ private function createMergedProperty(
             $propertyData['propertyData']['id'] ?? $compositionProperty->getName()
         );
 
+        // check if the merged property already has been generated
+        if (isset(self::$generatedMergedProperties[$mergedClassName])) {
+            return self::$generatedMergedProperties[$mergedClassName];
+        }
+
         $mergedPropertySchema = new Schema($mergedClassName);
         $mergedProperty = new Property('MergedProperty', $mergedClassName);
+        self::$generatedMergedProperties[$mergedClassName] = $mergedProperty;
 
         foreach ($properties as $property) {
             if ($property->getNestedSchema()) {

tests/Basic/BasicSchemaGenerationTest.php

@@ -2,6 +2,7 @@
 
 namespace PHPModelGenerator\Tests\Basic;
 
+use PHPModelGenerator\Exception\FileSystemException;
 use PHPModelGenerator\Exception\SchemaException;
 use PHPModelGenerator\ModelGenerator;
 use PHPModelGenerator\Model\GeneratorConfiguration;
@@ -233,4 +234,12 @@ public function testIdenticalSchemasAreMappedToOneClass(): void
             $reflection->getProperty('object2')->getDocComment()
         );
     }
+
+    public function testDuplicateIdThrowsAnException(): void
+    {
+        $this->expectException(FileSystemException::class);
+        $this->expectExceptionMessageMatches('/File (.*) already exists. Make sure object IDs are unique./');
+
+        $this->generateClassFromFile('DuplicateId.json');
+    }
 }

tests/Schema/BasicSchemaGenerationTest/DuplicateId.json

@@ -0,0 +1,23 @@
+{
+  "type": "object",
+  "properties": {
+    "property": {
+      "type": "object",
+      "id": "Person",
+      "properties": {
+        "name": {
+          "type": "string"
+        }
+      }
+    },
+    "property2": {
+      "type": "object",
+      "id": "Person",
+      "properties": {
+        "age": {
+          "type": "integer"
+        }
+      }
+    }
+  }
+}

tests/bootstrap.php

@@ -1,6 +1,6 @@
 <?php
 
-const FAILED_CLASSES_PATH = __DIR__ . '/../Failed-classes/';
+const FAILED_CLASSES_PATH = __DIR__ . '/../failed-classes/';
 
 if (is_dir(FAILED_CLASSES_PATH)) {
     $di = new RecursiveDirectoryIterator(FAILED_CLASSES_PATH, FilesystemIterator::SKIP_DOTS);