Fix Reader feed image display for VIDEO card types (#22325)

* Fix Reader feed image display for VIDEO card types

- VIDEO cards now show featured images when available
- Updated buildFeaturedImageVisibility() to support VIDEO cards with images
- Updated buildFeaturedImageUrl() for consistent behavior across card types
- Added comprehensive unit tests for VIDEO card image display
- Fixes issue where VIDEO posts with thumbnails didn't show images

Fixes #21332

* Remove unused imports (PHOTO, DEFAULT)

- Removed unused ReaderCardType.PHOTO import
- Removed unused ReaderCardType.DEFAULT import
- Addresses SonarCloud code analysis warnings

---------

Co-authored-by: Adalberto Plaza <adalpari@gmail.com>

Author: AdamLiga

WordPress/src/main/java/org/wordpress/android/ui/reader/discover/ReaderPostUiStateBuilder.kt

@@ -6,9 +6,7 @@ import kotlinx.coroutines.withContext
 import org.wordpress.android.R
 import org.wordpress.android.fluxc.store.AccountStore
 import org.wordpress.android.models.ReaderBlog
-import org.wordpress.android.models.ReaderCardType.DEFAULT
 import org.wordpress.android.models.ReaderCardType.GALLERY
-import org.wordpress.android.models.ReaderCardType.PHOTO
 import org.wordpress.android.models.ReaderCardType.VIDEO
 import org.wordpress.android.models.ReaderPost
 import org.wordpress.android.models.ReaderTag
@@ -282,17 +280,21 @@ class ReaderPostUiStateBuilder @Inject constructor(
     // TODO malinjir show overlay when buildFullVideoUrl != null
     private fun buildVideoOverlayVisibility(post: ReaderPost) = post.cardType == VIDEO
 
-    private fun buildFeaturedImageVisibility(post: ReaderPost) =
-        (post.cardType == PHOTO || post.cardType == DEFAULT) && post.hasFeaturedImage() ||
-                post.cardType == VIDEO && post.hasFeaturedVideo()
+    private fun buildFeaturedImageVisibility(post: ReaderPost): Boolean {
+        return when (post.cardType) {
+            GALLERY -> false
+            VIDEO -> post.hasFeaturedVideo() || post.hasFeaturedImage()
+            else -> post.hasFeaturedImage()
+        }
+    }
 
     private fun buildThumbnailStripUrls(post: ReaderPost) =
         post.takeIf { it.cardType == GALLERY }
             ?.let { retrieveGalleryThumbnailUrls(post) }
 
     private fun buildFeaturedImageUrl(post: ReaderPost, photonWidth: Int, photonHeight: Int): String? {
         return post
-            .takeIf { (it.cardType == PHOTO || it.cardType == DEFAULT) && it.hasFeaturedImage() }
+            .takeIf { it.cardType != GALLERY && it.hasFeaturedImage() }
             ?.getFeaturedImageForDisplay(photonWidth, photonHeight)
     }
 

WordPress/src/test/java/org/wordpress/android/ui/reader/discover/ReaderPostUiStateBuilderTest.kt

@@ -312,10 +312,10 @@ class ReaderPostUiStateBuilderTest : BaseUnitTest() {
 
     // region FEATURED IMAGE
     @Test
-    fun `featured image is displayed for photo and default card types`() = test {
+    fun `featured image is displayed for supported card types`() = test {
         // Arrange
         val dummyUrl = "12345"
-        ReaderCardType.values().filter { it == PHOTO || it == DEFAULT }.forEach {
+        ReaderCardType.values().filter { it != GALLERY }.forEach {
             val post = createPost(cardType = it, hasFeaturedImage = true, featuredImageUrlForDisplay = dummyUrl)
             // Act
             val uiState = mapPostToUiState(post)
@@ -325,10 +325,10 @@ class ReaderPostUiStateBuilderTest : BaseUnitTest() {
     }
 
     @Test
-    fun `featured image is displayed for photo and default card types for new UI`() = test {
+    fun `featured image is displayed for supported card types for new UI`() = test {
         // Arrange
         val dummyUrl = "12345"
-        ReaderCardType.values().filter { it == PHOTO || it == DEFAULT }.forEach {
+        ReaderCardType.values().filter { it != GALLERY }.forEach {
             val post = createPost(cardType = it, hasFeaturedImage = true, featuredImageUrlForDisplay = dummyUrl)
             // Act
             val uiState = mapPostToUiState(post)
@@ -338,27 +338,23 @@ class ReaderPostUiStateBuilderTest : BaseUnitTest() {
     }
 
     @Test
-    fun `featured image is not displayed for other than photo and default card types`() = test {
+    fun `featured image is not displayed for gallery card type`() = test {
         // Arrange
-        ReaderCardType.values().filter { it != PHOTO && it != DEFAULT }.forEach {
-            val post = createPost(cardType = it, hasFeaturedImage = true)
-            // Act
-            val uiState = mapPostToUiState(post)
-            // Assert
-            assertThat(uiState.featuredImageUrl).isNull()
-        }
+        val post = createPost(cardType = GALLERY, hasFeaturedImage = true)
+        // Act
+        val uiState = mapPostToUiState(post)
+        // Assert
+        assertThat(uiState.featuredImageUrl).isNull()
     }
 
     @Test
-    fun `featured image is not displayed for other than photo and default card types for new UI`() = test {
+    fun `featured image is not displayed for gallery card type for new UI`() = test {
         // Arrange
-        ReaderCardType.values().filter { it != PHOTO && it != DEFAULT }.forEach {
-            val post = createPost(cardType = it, hasFeaturedImage = true)
-            // Act
-            val uiState = mapPostToUiState(post)
-            // Assert
-            assertThat(uiState.featuredImageUrl).isNull()
-        }
+        val post = createPost(cardType = GALLERY, hasFeaturedImage = true)
+        // Act
+        val uiState = mapPostToUiState(post)
+        // Assert
+        assertThat(uiState.featuredImageUrl).isNull()
     }
 
     @Test
@@ -380,6 +376,21 @@ class ReaderPostUiStateBuilderTest : BaseUnitTest() {
         // Assert
         assertThat(uiState.featuredImageUrl).isNull()
     }
+
+    @Test
+    fun `video card shows featured media area when only video is available`() = test {
+        // Arrange
+        val post = createPost(
+            cardType = VIDEO,
+            hasFeaturedVideo = true,
+            featuredVideoUrl = "video://example",
+            hasFeaturedImage = false
+        )
+        // Act
+        val uiState = mapPostToUiState(post)
+        // Assert
+        assertThat(uiState.featuredImageVisibility).isTrue
+    }
     // endregion
 
     // region TITLE & EXCERPT