From 21776e2f846746a9f25a59397ea8c72d69215efb Mon Sep 17 00:00:00 2001 From: Alan Smith Date: Fri, 24 Oct 2025 14:57:38 -0400 Subject: [PATCH 1/2] Start of testing checklist --- docs/testing_before_pr_checklist.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 docs/testing_before_pr_checklist.md diff --git a/docs/testing_before_pr_checklist.md b/docs/testing_before_pr_checklist.md new file mode 100644 index 00000000..fbff51ef --- /dev/null +++ b/docs/testing_before_pr_checklist.md @@ -0,0 +1,22 @@ +For each PR, make sure each of these works + +# New items +* [ ] Make a new project and make sure you can edit in Robot and TeleOp +* [ ] Add an opmode "Auto" from the + next to Tabs +* [ ] Add a mechanism "Arm" from the + next to Tabs +# Using robot +* [ ] Add a component to the Robot +* [ ] Add a mechanism to the Robot +* [ ] Make sure component and Mechanism show up in toolbox for Opmode +# Events +* [ ] Add an event to the Mechanism +* [ ] In Robot, make sure you can see the event +* [ ] In Opmode, make sure you can see the event +# Mechanims +* [ ] Add a public component to the mechanism +* [ ] Add a private component to the mechanism +* [ ] Make sure that in the Robot you can see the public component (and not the private one) +# Code Generation +* [ ] Generate code (right now "Deploy") and make sure there are no errors + + \ No newline at end of file From f4584e8264f6621fc7dd4211cd1fb87fe98af6d0 Mon Sep 17 00:00:00 2001 From: Alan Smith Date: Sat, 25 Oct 2025 08:47:47 -0400 Subject: [PATCH 2/2] Addressing review comments --- docs/testing_before_pr_checklist.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/testing_before_pr_checklist.md b/docs/testing_before_pr_checklist.md index fbff51ef..32a598b2 100644 --- a/docs/testing_before_pr_checklist.md +++ b/docs/testing_before_pr_checklist.md @@ -7,16 +7,16 @@ For each PR, make sure each of these works # Using robot * [ ] Add a component to the Robot * [ ] Add a mechanism to the Robot -* [ ] Make sure component and Mechanism show up in toolbox for Opmode +* [ ] When editing an OpMode, make sure the component shows up in the toolbox Robot -> Components -> +* [ ] When editing an OpMode, make sure the mechanism shows up in the toolbox Robot -> Mechanisms -> my_arm # Events * [ ] Add an event to the Mechanism -* [ ] In Robot, make sure you can see the event -* [ ] In Opmode, make sure you can see the event +* [ ] In Robot, make sure you can see the event handler in the toolbox Robot -> Mechanisms -> my_arm -> Events +* [ ] In Opmode, make sure you can see the event handler in the toolbox Robot -> Mechanisms -> my_arm -> Events # Mechanims * [ ] Add a public component to the mechanism * [ ] Add a private component to the mechanism -* [ ] Make sure that in the Robot you can see the public component (and not the private one) +* [ ] Make sure that in the Robot you can see the public component (and not the private one) in the toolbox # Code Generation -* [ ] Generate code (right now "Deploy") and make sure there are no errors - - \ No newline at end of file +* [ ] Generate code (right now "Deploy") and make sure there are no errors in the console +* [ ] Check that the deploy zip file contains robot.py, teleop.py, auto.py, and arm.py. \ No newline at end of file