Skip to content

Commit 047777b

Browse files
jonyofelixfbecker
authored andcommitted
fix: do not send continue events (#307)
A debug adapter is not expected to send this event in response to a request that implies that execution continues, e.g. 'launch' or 'continue'. It is only necessary to send a 'continued' event if there was no previous request that implied this. Note: there is still the problem that it will seem to "hang" when you continue and the PHP code takes a while to run, #308 will fix that. Fixes #301
1 parent 7fa2d28 commit 047777b

File tree

2 files changed

+0
-9
lines changed

2 files changed

+0
-9
lines changed

src/phpDebug.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -279,10 +279,6 @@ class PhpDebugSession extends vscode.DebugSession {
279279
})
280280
connection.on('error', disposeConnection)
281281
connection.on('close', disposeConnection)
282-
connection.on('before-execute-command', () => {
283-
// It is about to start executing PHP code
284-
this.sendEvent(new vscode.ContinuedEvent(connection.id))
285-
})
286282
await connection.waitForInitPacket()
287283

288284
// override features from launch.json

src/xdebugConnection.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -679,11 +679,6 @@ export class Connection extends DbgpConnection {
679679
const data = iconv.encode(commandString, ENCODING)
680680
this._pendingCommands.set(transactionId, command)
681681
this._pendingExecuteCommand = command.isExecuteCommand
682-
if (this._pendingExecuteCommand) {
683-
// Since PHP execution commands block anything on the connection until it is
684-
// done executing, emit that the connection is about to go into such a locked state
685-
this.emit('before-execute-command')
686-
}
687682
await this.write(data)
688683
}
689684

0 commit comments

Comments
 (0)