Skip to content

Commit 9a73045

Browse files
authored
fix: Fixed semver dependency error. (#625)
* fix: Fixed semver dependency error. * Move semver to main dependencies, fix problematic semver usage. Co-authored-by: Damjan Cvetko <damjan.cvetko@monotek.net>
1 parent 4eda887 commit 9a73045

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44

55
The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
66

7+
## [1.16.3]
8+
9+
## Fixed
10+
11+
- Fixed semver dependency error.
12+
713
## [1.16.2]
814

915
## Fixed

package-lock.json

Lines changed: 2 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
"urlencode": "^1.1.0",
5050
"vscode-debugadapter": "^1.47.0",
5151
"vscode-debugprotocol": "^1.47.0",
52+
"semver": "^7.3.5",
5253
"xmldom": "^0.6.0"
5354
},
5455
"devDependencies": {
@@ -71,7 +72,6 @@
7172
"prettier": "2.3.2",
7273
"semantic-release": "^17.4.4",
7374
"semantic-release-vsce": "^3.4.1",
74-
"semver": "^7.3.5",
7575
"tslint": "^5.20.1",
7676
"tslint-config-prettier": "^1.18.0",
7777
"typescript": "^4.3.5",

src/phpDebug.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,9 @@ class PhpDebugSession extends vscode.DebugSession {
319319
// support for breakpoints
320320
let feat: xdebug.FeatureGetResponse
321321
const supportedEngine =
322-
initPacket.engineName === 'Xdebug' && semver.gte(initPacket.engineVersion, '3.0.0')
322+
initPacket.engineName === 'Xdebug' &&
323+
semver.valid(initPacket.engineVersion, { loose: true }) &&
324+
semver.gte(initPacket.engineVersion, '3.0.0', { loose: true })
323325
if (
324326
supportedEngine ||
325327
((feat = await connection.sendFeatureGetCommand('resolved_breakpoints')) &&

0 commit comments

Comments
 (0)