Fix PMD

Author: AB-xdev

eclipse-store-afs-ibm-cos/src/main/java/software/xdev/eclipse/store/afs/ibm/access/SingleAccessManager.java

@@ -213,7 +213,7 @@ private boolean isNotThisTokenFile(final S3ObjectSummary s3ObjectSummary)
 		return !s3ObjectSummary.getKey().equals(this.token.getFileName());
 	}
 
-	@SuppressWarnings("MagicNumber")
+	@SuppressWarnings({"MagicNumber", "PMD.ReplaceJavaUtilCalendar", "PMD.ReplaceJavaUtilDate"})
 	private boolean isOldTokenFile(final S3ObjectSummary s3ObjectSummary)
 	{
 		final Calendar deadlineForOldToken = Calendar.getInstance();

eclipse-store-afs-ibm-cos/src/main/java/software/xdev/eclipse/store/afs/ibm/cos/types/CosConnector.java

@@ -22,7 +22,10 @@
 import java.io.IOException;
 import java.nio.Buffer;
 import java.nio.ByteBuffer;
+import java.util.Collections;
 import java.util.List;
+import java.util.Map;
+import java.util.WeakHashMap;
 import java.util.regex.Pattern;
 import java.util.stream.Stream;
 import java.util.stream.StreamSupport;
@@ -95,6 +98,9 @@ class Default
 		extends BlobStoreConnector.Abstract<S3ObjectSummary>
 		implements CosConnector
 	{
+		private static final Map<String, Pattern> PREFIX_PATTERN_CACHE =
+			Collections.synchronizedMap(new WeakHashMap<>());
+		
 		public static final int READ_LIMIT = Integer.MAX_VALUE;
 		private final AmazonS3 s3;
 
@@ -112,11 +118,14 @@ class Default
 			this.s3 = s3;
 		}
 
+		@SuppressWarnings("PMD.AvoidRecompilingPatterns")
 		@Override
 		protected Stream<S3ObjectSummary> blobs(final BlobStorePath file)
 		{
 			final String prefix = toBlobKeyPrefix(file);
-			final Pattern pattern = Pattern.compile(blobKeyRegex(prefix));
+			final Pattern pattern = PREFIX_PATTERN_CACHE.computeIfAbsent(
+				prefix,
+				s -> Pattern.compile(blobKeyRegex(s)));
 			final ListObjectsV2Request request = new ListObjectsV2Request()
 				.withBucketName(file.container())
 				.withPrefix(prefix);

eclipse-store-afs-ibm-cos/src/main/java/software/xdev/eclipse/store/afs/ibm/cos/types/CosPathValidator.java

@@ -30,6 +30,14 @@ static CosPathValidator New()
 
 	class Default implements CosPathValidator
 	{
+		private static final Pattern LOWERCASE_NUMBERS_PERIOD_DASHES =
+			Pattern.compile("[a-z0-9\\.\\-]*");
+		private static final Pattern LOWERCASE_NUMBER =
+			Pattern.compile("[a-z0-9]");
+		private static final Pattern IP_ADDRESS_STYLE =
+			Pattern.compile(
+				"^((0|1\\d?\\d?|2[0-4]?\\d?|25[0-5]?|[3-9]\\d?)\\.){3}(0|1\\d?\\d?|2[0-4]?\\d?|25[0-5]?|[3-9]\\d?)$");
+		
 		Default()
 		{
 			super();
@@ -54,13 +62,13 @@ void validateBucketName(final String bucketName)
 			{
 				throw new IllegalArgumentException("bucket name must be between 3 and 63 characters long");
 			}
-			if(!Pattern.matches("[a-z0-9\\.\\-]*", bucketName))
+			if(!LOWERCASE_NUMBERS_PERIOD_DASHES.matcher(bucketName).matches())
 			{
 				throw new IllegalArgumentException(
 					"bucket name can contain only lowercase letters, numbers, periods (.) and dashes (-)"
 				);
 			}
-			if(!Pattern.matches("[a-z0-9]", bucketName.substring(0, 1)))
+			if(LOWERCASE_NUMBER.matcher(bucketName.substring(0, 1)).matches())
 			{
 				throw new IllegalArgumentException("bucket name must begin with a lowercase letters or a number");
 			}
@@ -77,10 +85,7 @@ void validateBucketName(final String bucketName)
 			{
 				throw new IllegalArgumentException("bucket name cannot have dashes adjacent to periods (.- or -.)");
 			}
-			if(Pattern.matches(
-				"^((0|1\\d?\\d?|2[0-4]?\\d?|25[0-5]?|[3-9]\\d?)\\.){3}(0|1\\d?\\d?|2[0-4]?\\d?|25[0-5]?|[3-9]\\d?)$",
-				bucketName
-			))
+			if(IP_ADDRESS_STYLE.matcher(bucketName).matches())
 			{
 				throw new IllegalArgumentException("bucket name must not be in an IP address style");
 			}

eclipse-store-afs-ibm-cos/src/test/java/software/xdev/eclipse/store/afs/ibm/access/CosAccessCommunicatorLocal.java

@@ -53,6 +53,7 @@ public synchronized boolean checkIfFileExists(final String fileName)
 		return this.existingFiles.containsKey(fileName);
 	}
 
+	@SuppressWarnings("PMD.ReplaceJavaUtilDate")
 	@Override
 	public synchronized void createEmptyFile(final String fileName)
 	{

eclipse-store-afs-ibm-cos/src/test/java/software/xdev/eclipse/store/afs/ibm/access/SingleAccessManagerTest.java

@@ -116,7 +116,8 @@ public void run()
 	 * Starts a lot of threads which all want the same, single access. If they all finish without deadlock and no
 	 * Access-files are left, the test is successful.
 	 */
-	@SuppressWarnings("PMD.LambdaCanBeMethodReference") // Multiple options for Lambda
+	@SuppressWarnings({"PMD.LambdaCanBeMethodReference", "PMD.AvoidFutureGetWithoutTimeout"})
+	// Multiple options for Lambda
 	@Test
 	void waitForAndReserveSingleAccessWaitingNeededManyManagers()
 	{
@@ -140,6 +141,8 @@ void waitForAndReserveSingleAccessWaitingNeededManyManagers()
 
 		// Only the last manager is allowed to still have the AccessToken file
 		Assertions.assertEquals(1, this.communicator.getExistingFilesWithPrefix().size());
+		
+		executor.shutdown();
 	}
 
 	@Test