fix: argument list too long

Author: xiaoyu2er

.github/actions/check-locale-changes/action.yml

@@ -56,9 +56,12 @@ runs:
           # For manual trigger, we don't need changes JSON
           output=$(.github/scripts/generate-locale-matrix.sh "$trigger_type" "$manual_locales")
         else
-          # For auto/docs-pr triggers, pass the changes JSON
+          # For auto/docs-pr triggers, write changes JSON to temp file to avoid ARG_MAX limit
           changes_json='${{ toJSON(steps.changes.outputs) }}'
-          output=$(.github/scripts/generate-locale-matrix.sh "$trigger_type" "" "$changes_json")
+          temp_file=$(mktemp)
+          echo "$changes_json" > "$temp_file"
+          output=$(.github/scripts/generate-locale-matrix.sh "$trigger_type" "" "$temp_file")
+          rm -f "$temp_file"
         fi
         
         # Parse the output (the script outputs two lines: include= and has-changes=)

.github/scripts/generate-locale-matrix.sh

@@ -1,11 +1,11 @@
 #!/bin/bash
 
 # Script to generate locale deployment matrix based on trigger type and changes
-# Usage: ./generate-locale-matrix.sh <trigger-type> [manual-locales] [changes-json]
+# Usage: ./generate-locale-matrix.sh <trigger-type> [manual-locales] [changes-json-file]
 #
 # trigger-type: "manual", "auto", or "docs-pr"
 # manual-locales: comma-separated list of locales (for manual trigger)
-# changes-json: JSON output from changed-files action (for auto/docs-pr triggers)
+# changes-json-file: File path containing JSON output from changed-files action (for auto/docs-pr triggers)
 
 set -e
 
@@ -20,17 +20,17 @@ LOCALE_CONFIG_FILE="$ROOT_DIR/.github/locales-config.json"
 
 # Function to print usage
 usage() {
-    echo "Usage: $0 <trigger-type> [manual-locales] [changes-json]"
+    echo "Usage: $0 <trigger-type> [manual-locales] [changes-json-file]"
     echo ""
     echo "Arguments:"
-    echo "  trigger-type    Type of trigger: 'manual', 'auto', or 'docs-pr'"
-    echo "  manual-locales  Comma-separated list of locales (optional, for manual trigger)"
-    echo "  changes-json    JSON output from changed-files action (for auto/docs-pr triggers)"
+    echo "  trigger-type       Type of trigger: 'manual', 'auto', or 'docs-pr'"
+    echo "  manual-locales     Comma-separated list of locales (optional, for manual trigger)"
+    echo "  changes-json-file  File path containing JSON output from changed-files action (for auto/docs-pr triggers)"
     echo ""
     echo "Examples:"
     echo "  $0 manual"
     echo "  $0 manual 'en,zh-hans'"
-    echo "  $0 docs-pr '{\"core_any_changed\": \"true\", \"en_any_changed\": \"false\"}'"
+    echo "  $0 docs-pr '/tmp/changes.json'"
     exit 1
 }
 
@@ -186,7 +186,7 @@ process_auto_trigger() {
 main() {
     local trigger_type="$1"
     local manual_locales="$2"
-    local changes_json="$3"
+    local changes_json_file="$3"
 
     # Validate arguments
     if [ -z "$trigger_type" ]; then
@@ -231,15 +231,28 @@ main() {
         matrix_include="$RESULT_MATRIX_INCLUDE"
         has_changes="$RESULT_HAS_CHANGES"
     else
-        # For auto and docs-pr triggers, changes_json is required
-        if [ -z "$changes_json" ]; then
-            echo "Error: changes-json is required for auto/docs-pr triggers" >&2
+        # For auto and docs-pr triggers, changes_json_file is required
+        if [ -z "$changes_json_file" ]; then
+            echo "Error: changes-json-file is required for auto/docs-pr triggers" >&2
             usage
         fi
 
+        # Check if changes JSON file exists
+        if [ ! -f "$changes_json_file" ]; then
+            echo "Error: Changes JSON file not found: $changes_json_file" >&2
+            exit 1
+        fi
+        
+        # Read changes JSON from file
+        local changes_json
+        if ! changes_json=$(cat "$changes_json_file"); then
+            echo "Error: Failed to read changes JSON file: $changes_json_file" >&2
+            exit 1
+        fi
+        
         # Validate changes JSON
         if ! validate_json "$changes_json"; then
-            echo "Error: Invalid changes JSON provided" >&2
+            echo "Error: Invalid changes JSON in file: $changes_json_file" >&2
             exit 1
         fi
 

.github/scripts/test-locale-scripts.sh

@@ -97,37 +97,49 @@ main() {
 
     print_header "Test 4: Auto Trigger - No Changes"
     local no_changes_json='{"core_any_changed": "false", "en_any_changed": "false", "zh-hans_any_changed": "false"}'
+    local temp_file=$(mktemp)
+    echo "$no_changes_json" > "$temp_file"
     if run_test "Auto trigger (no changes)" \
-               "$SCRIPT_DIR/generate-locale-matrix.sh auto '' '$no_changes_json'" \
+               "$SCRIPT_DIR/generate-locale-matrix.sh auto '' '$temp_file'" \
                "has-changes=false"; then
         ((passed_count++))
     fi
+    rm -f "$temp_file"
     ((test_count++))
 
     print_header "Test 5: Auto Trigger - Core Changes"
     local core_changes_json='{"core_any_changed": "true", "en_any_changed": "false", "zh-hans_any_changed": "false"}'
+    local temp_file=$(mktemp)
+    echo "$core_changes_json" > "$temp_file"
     if run_test "Auto trigger (core changes)" \
-               "$SCRIPT_DIR/generate-locale-matrix.sh auto '' '$core_changes_json'" \
+               "$SCRIPT_DIR/generate-locale-matrix.sh auto '' '$temp_file'" \
                "has-changes=true"; then
         ((passed_count++))
     fi
+    rm -f "$temp_file"
     ((test_count++))
 
     print_header "Test 6: Auto Trigger - Locale Changes"
     local locale_changes_json='{"core_any_changed": "false", "en_any_changed": "true", "zh-hans_any_changed": "false"}'
+    local temp_file=$(mktemp)
+    echo "$locale_changes_json" > "$temp_file"
     if run_test "Auto trigger (locale changes)" \
-               "$SCRIPT_DIR/generate-locale-matrix.sh auto '' '$locale_changes_json'" \
+               "$SCRIPT_DIR/generate-locale-matrix.sh auto '' '$temp_file'" \
                "has-changes=true"; then
         ((passed_count++))
     fi
+    rm -f "$temp_file"
     ((test_count++))
 
     print_header "Test 7: Docs PR Trigger"
+    local temp_file=$(mktemp)
+    echo "$core_changes_json" > "$temp_file"
     if run_test "Docs PR trigger" \
-               "$SCRIPT_DIR/generate-locale-matrix.sh docs-pr '' '$core_changes_json'" \
+               "$SCRIPT_DIR/generate-locale-matrix.sh docs-pr '' '$temp_file'" \
                "has-changes=true"; then
         ((passed_count++))
     fi
+    rm -f "$temp_file"
     ((test_count++))
 
     print_header "Test 8: Error Handling - Invalid Trigger Type"