small optimization: using strings.Contains instead regexp.MatchString

reinventer · reinventer · commit 9d6d3110b8a8 · 2019-06-23T11:42:46.000+03:00
diff --git a/authorization.go b/authorization.go
@@ -9,7 +9,6 @@ import (
 	"hash"
 	"io"
 	"net/url"
-	"regexp"
 	"strings"
 	"time"
 )
@@ -105,7 +104,7 @@ func (ah *authorization) computeA1(dr *DigestRequest) string {
 
 func (ah *authorization) computeA2(dr *DigestRequest) string {
 
-	if matched, _ := regexp.MatchString("auth-int", dr.Wa.Qop); matched {
+	if strings.Contains(dr.Wa.Qop, "auth-int") {
 		ah.Qop = "auth-int"
 		return fmt.Sprintf("%s:%s:%s", dr.Method, ah.URI, ah.hash(dr.Body))
 	}

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@ import (`
`9`	`9`	`"hash"`
`10`	`10`	`"io"`
`11`	`11`	`"net/url"`
`12`		`- "regexp"`
`13`	`12`	`"strings"`
`14`	`13`	`"time"`
`15`	`14`	`)`
`@@ -105,7 +104,7 @@ func (ah authorization) computeA1(dr DigestRequest) string {`
`105`	`104`
`106`	`105`	`func (ah authorization) computeA2(dr DigestRequest) string {`
`107`	`106`
`108`		`- if matched, _ := regexp.MatchString("auth-int", dr.Wa.Qop); matched {`
	`107`	`+ if strings.Contains(dr.Wa.Qop, "auth-int") {`
`109`	`108`	`ah.Qop = "auth-int"`
`110`	`109`	`return fmt.Sprintf("%s:%s:%s", dr.Method, ah.URI, ah.hash(dr.Body))`
`111`	`110`	`}`