Let's scale our maximum attenuation correctly...

GregorR · GregorR · commit 1eb410f0a93b · 2019-04-24T16:56:03.000-04:00
diff --git a/src/denoise.c b/src/denoise.c
@@ -524,11 +524,10 @@ float rnnoise_process_frame(DenoiseState *st, float *out, const float *in) {
       if (min < st->max_attenuation) {
         if (min < MIN_MAX_ATTENUATION)
           min = MIN_MAX_ATTENUATION;
-        mult = st->max_attenuation / min;
+        mult = (1.0f-st->max_attenuation) / (1.0f-min);
         for (i=0;i<NB_BANDS;i++) {
           if (g[i] < MIN_MAX_ATTENUATION) g[i] = MIN_MAX_ATTENUATION;
-          g[i] *= mult;
-          if (g[i] > 1) g[i] = 1;
+          g[i] = 1.0f-((1.0f-g[i]) * mult);
           st->lastg[i] = g[i];
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -524,11 +524,10 @@ float rnnoise_process_frame(DenoiseState st, float out, const float *in) {`
`524`	`524`	`if (min < st->max_attenuation) {`
`525`	`525`	`if (min < MIN_MAX_ATTENUATION)`
`526`	`526`	`min = MIN_MAX_ATTENUATION;`
`527`		`- mult = st->max_attenuation / min;`
	`527`	`+ mult = (1.0f-st->max_attenuation) / (1.0f-min);`
`528`	`528`	`for (i=0;i<NB_BANDS;i++) {`
`529`	`529`	`if (g[i] < MIN_MAX_ATTENUATION) g[i] = MIN_MAX_ATTENUATION;`
`530`		`- g[i] *= mult;`
`531`		`- if (g[i] > 1) g[i] = 1;`
	`530`	`+ g[i] = 1.0f-((1.0f-g[i]) * mult);`
`532`	`531`	`st->lastg[i] = g[i];`
`533`	`532`	`}`
`534`	`533`	`}`