Merge pull request #2224 from serge-sans-paille/fix/warnings

Fix various warnings

Author: JohanMabille

include/xtensor/xmasked_view.hpp

@@ -160,6 +160,8 @@ namespace xt
         template <class D, class M>
         xmasked_view(D&& data, M&& mask);
 
+        xmasked_view(xmasked_view const&) = default;
+
         size_type size() const noexcept;
         const inner_shape_type& shape() const noexcept;
         const inner_strides_type& strides() const noexcept;

include/xtensor/xmath.hpp

@@ -2694,9 +2694,10 @@ namespace detail {
         // note: forcing copy of first axes argument -- is there a better solution?
         auto axes_copy = axes;
         using value_type = typename std::conditional_t<std::is_same<T, void>::value, double, T>;
+        using sum_type = typename std::conditional_t<std::is_same<T, void>::value, typename std::common_type_t<typename std::decay_t<E>::value_type, value_type>, T>;
         // sum cannot always be a double. It could be a complex number which cannot operate on
         // std::plus<double>.
-        return nansum<T>(sc, std::forward<X>(axes), es) / xt::cast<value_type>(count_nonnan(sc, std::move(axes_copy), es));
+        return nansum<sum_type>(sc, std::forward<X>(axes), es) / xt::cast<value_type>(count_nonnan(sc, std::move(axes_copy), es));
     }
 
     template <class T = void, class E, class EVS = DEFAULT_STRATEGY_REDUCERS,
@@ -2705,7 +2706,8 @@ namespace detail {
     {
         decltype(auto) sc = detail::shared_forward<E>(e);
         using value_type = typename std::conditional_t<std::is_same<T, void>::value, double, T>;
-        return nansum<T>(sc, es) / xt::cast<value_type>(count_nonnan(sc, es));
+        using sum_type = typename std::conditional_t<std::is_same<T, void>::value, typename std::common_type_t<typename std::decay_t<E>::value_type, value_type>, T>;
+        return nansum<sum_type>(sc, es) / xt::cast<value_type>(count_nonnan(sc, es));
     }
 
 #ifdef X_OLD_CLANG
@@ -2776,7 +2778,7 @@ namespace detail {
             keep_dim_shape[el] = 1;
         }
         auto mrv = reshape_view<XTENSOR_DEFAULT_LAYOUT>(std::move(inner_mean), std::move(keep_dim_shape));
-        return nanmean<result_type>(square(sc - std::move(mrv)), std::forward<X>(axes), es);
+        return nanmean<result_type>(square(cast<result_type>(sc) - std::move(mrv)), std::forward<X>(axes), es);
     }
 
     /**

include/xtensor/xview.hpp

@@ -230,7 +230,7 @@ namespace xt
         struct is_contiguous_view
             : std::integral_constant<bool,
                 has_data_interface<E>::value &&
-                !(E::static_layout == layout_type::column_major && static_dimension<typename E::shape_type>::value != sizeof...(S)) &&
+                !(E::static_layout == layout_type::column_major && static_cast<std::size_t>(static_dimension<typename E::shape_type>::value) != sizeof...(S)) &&
                 is_contiguous_view_impl<E::static_layout, true, false, false, xtl::mpl::vector<S...>>::value
               >
         {

test/test_xnpy.cpp

@@ -29,6 +29,9 @@ namespace xt
         case xtl::endian::little_endian:
             endianness = ".le";
             break;
+        case xtl::endian::mixed:
+            endianness = ".unsupported";
+            break;
         }
         return npy_prefix + lts + endianness + ".npy";
     }