Skip to content

Commit 10fe249

Browse files
committed
allow user+password to still match
1 parent 5143f90 commit 10fe249

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

addons/addon-web-links/src/WebLinkProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ function isUrl(urlString: string): boolean {
4949
: url.username
5050
? `${url.protocol}//${url.username}@${url.host}`
5151
: `${url.protocol}//${url.host}`;
52-
return urlString.toLocaleLowerCase().startsWith(parsedBase);
52+
return urlString.toLocaleLowerCase().startsWith(parsedBase.toLocaleLowerCase());
5353
} catch (e) {
5454
return false;
5555
}

addons/addon-web-links/test/WebLinksAddon.api.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,12 +129,14 @@ describe('WebLinksAddon', () => {
129129
const data = ` HTTP://EXAMPLE.COM \\r\\n` +
130130
` HTTPS://Example.com \\r\\n` +
131131
` HTTP://Example.com:80 \\r\\n` +
132-
` HTTP://Example.com:80/staysUpper \\r\\n`;
132+
` HTTP://Example.com:80/staysUpper \\r\\n` +
133+
` HTTP://Ab:xY@abc.com:80/staysUpper \\r\\n`;
133134
await writeSync(page, data);
134135
await pollForLinkAtCell(3, 0, `HTTP://EXAMPLE.COM`);
135136
await pollForLinkAtCell(3, 1, `HTTPS://Example.com`);
136137
await pollForLinkAtCell(3, 2, `HTTP://Example.com:80`);
137138
await pollForLinkAtCell(3, 3, `HTTP://Example.com:80/staysUpper`);
139+
await pollForLinkAtCell(3, 4, `HTTP://Ab:xY@abc.com:80/staysUpper`);
138140
});
139141
});
140142

0 commit comments

Comments
 (0)