Merge pull request #3588 from Tyriar/3505

Tyriar · web-flow · commit 86ad5198acaa · 2021-12-22T10:06:55.000-08:00
Log characters as a code array when parsing data as well
diff --git a/src/common/InputHandler.ts b/src/common/InputHandler.ts
@@ -544,7 +544,13 @@ export class InputHandler extends Disposable implements IInputHandler {
       }
     }
 
-    this._logService.debug('parsing data', data);
+    // Log debug data, the log level gate is to prevent extra work in this hot path
+    if (this._logService.logLevel <= LogLevelEnum.DEBUG) {
+      this._logService.debug(`parsing data${typeof data === 'string' ? ` "${data}"` : ''}`, typeof data === 'string'
+        ? data.split('').map(e => e.charCodeAt(0))
+        : data
+      );
+    }
 
     // resize input buffer if needed
     if (this._parseBuffer.length < data.length) {

Original file line number	Diff line number	Diff line change
`@@ -544,7 +544,13 @@ export class InputHandler extends Disposable implements IInputHandler {`
`544`	`544`	`}`
`545`	`545`	`}`
`546`	`546`
`547`		`- this._logService.debug('parsing data', data);`
	`547`	`+ // Log debug data, the log level gate is to prevent extra work in this hot path`
	`548`	`+ if (this._logService.logLevel <= LogLevelEnum.DEBUG) {`
	`549`	+ this._logService.debug(`parsing data${typeof data === 'string' ? ` "${data}"` : ''}`, typeof data === 'string'
	`550`	`+ ? data.split('').map(e => e.charCodeAt(0))`
	`551`	`+ : data`
	`552`	`+ );`
	`553`	`+ }`
`548`	`554`
`549`	`555`	`// resize input buffer if needed`
`550`	`556`	`if (this._parseBuffer.length < data.length) {`