Close generator before deleting it

Tyriar · Tyriar · commit 8b422442b707 · 2023-05-21T09:05:21.000-07:00
diff --git a/addons/xterm-addon-canvas/src/BaseRenderLayer.ts b/addons/xterm-addon-canvas/src/BaseRenderLayer.ts
@@ -386,6 +386,7 @@ export abstract class BaseRenderLayer extends Disposable implements IRenderLayer
     // something is wrong with either the lifecycle of _bitmapGenerator or the page canvases are
     // swapped out unexpectedly
     if (this._bitmapGenerator[glyph.texturePage] && this._charAtlas.pages[glyph.texturePage].canvas !== this._bitmapGenerator[glyph.texturePage]!.canvas) {
+      this._bitmapGenerator[glyph.texturePage]?.bitmap?.close();
       delete this._bitmapGenerator[glyph.texturePage];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -386,6 +386,7 @@ export abstract class BaseRenderLayer extends Disposable implements IRenderLayer`
`386`	`386`	`// something is wrong with either the lifecycle of _bitmapGenerator or the page canvases are`
`387`	`387`	`// swapped out unexpectedly`
`388`	`388`	`if (this._bitmapGenerator[glyph.texturePage] && this._charAtlas.pages[glyph.texturePage].canvas !== this._bitmapGenerator[glyph.texturePage]!.canvas) {`
	`389`	`+ this._bitmapGenerator[glyph.texturePage]?.bitmap?.close();`
`389`	`390`	`delete this._bitmapGenerator[glyph.texturePage];`
`390`	`391`	`}`
`391`	`392`