be safe and check if container contains element before removing

meganrogge · meganrogge · commit 8dfed8f97909 · 2022-02-11T17:08:08.000-06:00
diff --git a/src/browser/services/DecorationService.ts b/src/browser/services/DecorationService.ts
@@ -106,7 +106,7 @@ export class Decoration extends Disposable implements IDecoration {
   }
 
   private _createElement(renderService: IRenderService, shouldRecreate?: boolean): void {
-    if (shouldRecreate && this._element) {
+    if (shouldRecreate && this._element && this._container.contains(this._element)) {
       this._container.removeChild(this._element);
     }
     this._element = document.createElement('div');

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,7 @@ export class Decoration extends Disposable implements IDecoration {`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`private _createElement(renderService: IRenderService, shouldRecreate?: boolean): void {`
`109`		`- if (shouldRecreate && this._element) {`
	`109`	`+ if (shouldRecreate && this._element && this._container.contains(this._element)) {`
`110`	`110`	`this._container.removeChild(this._element);`
`111`	`111`	`}`
`112`	`112`	`this._element = document.createElement('div');`