Merge pull request #3360 from Tyriar/eslint_as

Add eslint type assertions rule

Author: Tyriar

.eslintrc.json

@@ -47,6 +47,7 @@
         "readonly": "generic"
       }
     ],
+    "@typescript-eslint/consistent-type-assertions": "warn",
     "@typescript-eslint/consistent-type-definitions": "warn",
     "@typescript-eslint/explicit-function-return-type": [
       "warn",

addons/xterm-addon-serialize/test/SerializeAddon.api.ts

@@ -487,9 +487,9 @@ function newArray<T>(initial: T | ((index: number) => T), count: number): T[] {
   const array: T[] = new Array<T>(count);
   for (let i = 0; i < array.length; i++) {
     if (typeof initial === 'function') {
-      array[i] = (<(index: number) => T>initial)(i);
+      array[i] = (initial as (index: number) => T)(i);
     } else {
-      array[i] = <T>initial;
+      array[i] = initial as T;
     }
   }
   return array;

addons/xterm-addon-webgl/src/WebglAddon.ts

@@ -24,9 +24,9 @@ export class WebglAddon implements ITerminalAddon {
       throw new Error('Cannot activate WebglAddon before Terminal.open');
     }
     this._terminal = terminal;
-    const renderService: IRenderService = (<any>terminal)._core._renderService;
-    const characterJoinerService: ICharacterJoinerService = (<any>terminal)._core._characterJoinerService;
-    const colors: IColorSet = (<any>terminal)._core._colorManager.colors;
+    const renderService: IRenderService = (terminal as any)._core._renderService;
+    const characterJoinerService: ICharacterJoinerService = (terminal as any)._core._characterJoinerService;
+    const colors: IColorSet = (terminal as any)._core._colorManager.colors;
     this._renderer = new WebglRenderer(terminal, colors, characterJoinerService, this._preserveDrawingBuffer);
     this._renderer.onContextLoss(() => this._onContextLoss.fire());
     renderService.setRenderer(this._renderer);

src/browser/AccessibilityManager.ts

@@ -112,7 +112,7 @@ export class AccessibilityManager extends Disposable {
   }
 
   private _onBoundaryFocus(e: FocusEvent, position: BoundaryPosition): void {
-    const boundaryElement = <HTMLElement>e.target;
+    const boundaryElement = e.target as HTMLElement;
     const beforeBoundaryElement = this._rowElements[position === BoundaryPosition.TOP ? 1 : this._rowElements.length - 2];
 
     // Don't scroll if the buffer top has reached the end in that direction

src/browser/ColorManager.test.ts

@@ -17,7 +17,7 @@ describe('ColorManager', () => {
     dom = new jsdom.JSDOM('');
     window = dom.window;
     document = window.document;
-    (<any>window).HTMLCanvasElement.prototype.getContext = () => ({
+    (window as any).HTMLCanvasElement.prototype.getContext = () => ({
       createLinearGradient(): any {
         return null;
       },
@@ -36,7 +36,7 @@ describe('ColorManager', () => {
       for (const key of Object.keys(cm.colors)) {
         if (key !== 'ansi' && key !== 'contrastCache') {
           // A #rrggbb or rgba(...)
-          assert.ok((<any>cm.colors)[key].css.length >= 7);
+          assert.ok((cm.colors as any)[key].css.length >= 7);
         }
       }
       assert.equal(cm.colors.ansi.length, 256);

src/browser/Linkifier.test.ts

@@ -174,7 +174,7 @@ describe('Linkifier', () => {
             assert.equal(mouseZoneManager.zones[0].y1, 1);
             assert.equal(mouseZoneManager.zones[0].y2, 1);
             // Fires done()
-            mouseZoneManager.zones[0].clickCallback(<any>{});
+            mouseZoneManager.zones[0].clickCallback({} as any);
           }
         });
         linkifier.linkifyRows();

src/browser/Linkifier.ts

@@ -89,7 +89,9 @@ export class Linkifier implements ILinkifier {
     if (this._rowsTimeoutId) {
       clearTimeout(this._rowsTimeoutId);
     }
-    this._rowsTimeoutId = <number><any>setTimeout(() => this._linkifyRows(), Linkifier._timeBeforeLatency);
+
+    // Cannot use window.setTimeout since tests need to run in node
+    this._rowsTimeoutId = setTimeout(() => this._linkifyRows(), Linkifier._timeBeforeLatency) as any as number;
   }
 
   /**

src/browser/Terminal.test.ts

@@ -29,10 +29,10 @@ describe('Terminal', () => {
   beforeEach(() => {
     term = new TestTerminal(termOptions);
     term.refresh = () => { };
-    (<any>term).renderer = new MockRenderer();
+    (term as any).renderer = new MockRenderer();
     term.viewport = new MockViewport();
-    (<any>term)._compositionHelper = new MockCompositionHelper();
-    (<any>term).element = {
+    (term as any)._compositionHelper = new MockCompositionHelper();
+    (term as any).element = {
       classList: {
         toggle: () => { },
         remove: () => { }
@@ -86,12 +86,12 @@ describe('Terminal', () => {
         assert.equal(e.domEvent instanceof Object, true);
         done();
       });
-      const evKeyPress = <KeyboardEvent>{
+      const evKeyPress = {
         preventDefault: () => { },
         stopPropagation: () => { },
         type: 'keypress',
         keyCode: 13
-      };
+      } as KeyboardEvent;
       term.keyPress(evKeyPress);
     });
     it('should fire a key event after a keydown DOM event', (done) => {
@@ -100,13 +100,13 @@ describe('Terminal', () => {
         assert.equal(e.domEvent instanceof Object, true);
         done();
       });
-      (<any>term).textarea = { value: '' };
-      const evKeyDown = <KeyboardEvent>{
+      (term as any).textarea = { value: '' };
+      const evKeyDown = {
         preventDefault: () => { },
         stopPropagation: () => { },
         type: 'keydown',
         keyCode: 13
-      };
+      } as KeyboardEvent;
       term.keyDown(evKeyDown);
     });
     it('should fire the onResize event', (done) => {
@@ -140,18 +140,18 @@ describe('Terminal', () => {
   });
 
   describe('attachCustomKeyEventHandler', () => {
-    const evKeyDown = <KeyboardEvent>{
+    const evKeyDown = {
       preventDefault: () => { },
       stopPropagation: () => { },
       type: 'keydown',
       keyCode: 77
-    };
-    const evKeyPress = <KeyboardEvent>{
+    } as KeyboardEvent;
+    const evKeyPress = {
       preventDefault: () => { },
       stopPropagation: () => { },
       type: 'keypress',
       keyCode: 77
-    };
+    } as KeyboardEvent;
 
     beforeEach(() => {
       term.clearSelection = () => { };
@@ -374,13 +374,13 @@ describe('Terminal', () => {
 
     describe('keyPress', () => {
       it('should scroll down, when a key is pressed and terminal is scrolled up', () => {
-        const event = <KeyboardEvent>{
+        const event = {
           type: 'keydown',
           key: 'a',
           keyCode: 65,
           preventDefault: () => { },
           stopPropagation: () => { }
-        };
+        } as KeyboardEvent;
 
         term.buffer.ydisp = 0;
         term.buffer.ybase = 40;
@@ -403,7 +403,7 @@ describe('Terminal', () => {
         assert.equal(term.buffer.ydisp, startYDisp);
         term.scrollLines(-1);
         assert.equal(term.buffer.ydisp, startYDisp - 1);
-        term.keyPress(<KeyboardEvent>{ keyCode: 0 });
+        term.keyPress({ keyCode: 0 });
         assert.equal(term.buffer.ydisp, startYDisp - 1);
       });
     });

src/browser/Terminal.ts

@@ -72,7 +72,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
 
   // private _visualBellTimer: number;
 
-  public browser: IBrowser = <any>Browser;
+  public browser: IBrowser = Browser as any;
 
   // TODO: We should remove options once components adopt optionsService
   public get options(): IInitializedTerminalOptions { return this.optionsService.options; }
@@ -601,7 +601,7 @@ export class Terminal extends CoreTerminal implements ITerminal {
 
       let but: CoreMouseButton;
       let action: CoreMouseAction | undefined;
-      switch ((<any>ev).overrideType || ev.type) {
+      switch ((ev as any).overrideType || ev.type) {
         case 'mousemove':
           action = CoreMouseAction.MOVE;
           if (ev.buttons === undefined) {

src/browser/TestUtils.test.ts

@@ -153,7 +153,7 @@ export class MockTerminal implements ITerminal {
   public textarea!: HTMLTextAreaElement;
   public rows!: number;
   public cols!: number;
-  public browser: IBrowser = <any>Browser;
+  public browser: IBrowser = Browser as any;
   public writeBuffer!: string[];
   public children!: HTMLElement[];
   public cursorHidden!: boolean;