Skip to content

Commit e08962b

Browse files
authored
Merge pull request #3649 from meganrogge/master
on buffer clear, update markers array once each has been disposed of
2 parents db1fd26 + f839a0d commit e08962b

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/common/InputHandler.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1218,7 +1218,6 @@ export class InputHandler extends Disposable implements IInputHandler {
12181218
this._activeBuffer.getNullCell(this._eraseAttrData()),
12191219
this._eraseAttrData()
12201220
);
1221-
this._bufferService.buffer.clearMarkers(y);
12221221
if (clearWrap) {
12231222
line.isWrapped = false;
12241223
}

src/common/buffer/Buffer.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -590,11 +590,13 @@ export class Buffer implements IBuffer {
590590
if (y) {
591591
for (const marker of this.markers.filter(m => m.line === y)) {
592592
marker.dispose();
593+
this.markers.splice(this.markers.indexOf(marker), 1);
593594
}
594595
} else {
595596
for (const marker of this.markers) {
596597
marker.dispose();
597598
}
599+
this.markers = [];
598600
}
599601
this._isClearing = false;
600602
}

0 commit comments

Comments
 (0)