Performance improvement (#27)

* WIP: Improve performance for 100k++ records

* Fix stan

* Use strval

* Use strval

* Remove unnecessary doc

* Remove hardcoded memory limit and timeout

Author: yajra

src/Jobs/DataTableExportJob.php

@@ -3,6 +3,7 @@
 namespace Yajra\DataTables\Jobs;
 
 use Carbon\Carbon;
+use Illuminate\Auth\Events\Login;
 use Illuminate\Bus\Batchable;
 use Illuminate\Bus\Queueable;
 use Illuminate\Contracts\Queue\ShouldBeUnique;
@@ -15,6 +16,7 @@
 use Illuminate\Support\Arr;
 use Illuminate\Support\Collection;
 use Illuminate\Support\Facades\Auth;
+use Illuminate\Support\Facades\Event;
 use Illuminate\Support\Facades\Storage;
 use Illuminate\Support\Str;
 use OpenSpout\Common\Helper\CellTypeHelper;
@@ -73,10 +75,12 @@ public function __construct(array $dataTable, array $request, $user, string $she
      * @throws \OpenSpout\Common\Exception\IOException
      * @throws \OpenSpout\Common\Exception\UnsupportedTypeException
      * @throws \OpenSpout\Writer\Exception\WriterNotOpenedException
+     * @throws \OpenSpout\Writer\Exception\InvalidSheetNameException
      */
     public function handle()
     {
         if ($this->user) {
+            Event::forget(Login::class);
             Auth::loginUsingId($this->user);
         }
 
@@ -90,23 +94,19 @@ public function handle()
         $dataTable = app()->call([$oTable, 'dataTable'], compact('query'));
         $dataTable->skipPaging();
 
-        /** @var string $exportType */
-        $exportType = request('exportType');
-
-        /** @var string $disk */
-        $disk = config('datatables-export.disk', 'local');
+        $exportType = strval(request('exportType'));
 
         $type = Str::startsWith($exportType, Type::CSV) ? Type::CSV : Type::XLSX;
         $filename = $this->batchId.'.'.$type;
 
-        $path = Storage::disk($disk)->path($filename);
+        $path = Storage::disk($this->getDisk())->path($filename);
 
         $writer = WriterEntityFactory::createWriter($type);
         $writer->openToFile($path);
 
         if ($writer instanceof XLSXWriter) {
             $sheet = $writer->getCurrentSheet();
-            $sheet->setName(substr($this->sheetName,0,31));
+            $sheet->setName(substr($this->sheetName, 0, 31));
         }
 
         $columns = $this->getExportableColumns($oTable);
@@ -116,39 +116,40 @@ public function handle()
             )
         );
 
-        if (config('datatables-export.method', 'lazy') === 'lazy') {
-            /** @var int $chunkSize */
-            $chunkSize = config('datatables-export.chunk', 1000);
-
+        if ($this->usesLazyMethod()) {
+            $chunkSize = intval(config('datatables-export.chunk', 1000));
             $query = $dataTable->getFilteredQuery()->lazy($chunkSize);
         } else {
             $query = $dataTable->getFilteredQuery()->cursor();
         }
 
         foreach ($query as $row) {
             $cells = [];
-            $columns->map(function (Column $column) use ($row, &$cells) {
+
+            if (! $row instanceof Model) {
+                $row = $row instanceof Arrayable ? $row->toArray() : (array) $row;
+            }
+
+            if ($this->usesLazyMethod() && is_array($row)) {
+                $row = Arr::flatten($row);
+            }
+
+            $defaultDateFormat = strval(config('datatables-export.default_date_format', 'yyyy-mm-dd'));
+
+            $columns->map(function (Column $column) use ($row, &$cells, $defaultDateFormat) {
                 $property = $column->data;
 
                 /* Handles orthogonal data */
                 if (is_array($property)) {
                     $property = $property['_'] ?? $column->name;
                 }
 
-                if (! $row instanceof Model) {
-                    $row = $row instanceof Arrayable ? $row->toArray() : (array) $row;
-                }
-
-                /** @var array|bool|int|string|null $value */
-                $value = Arr::get($row, $property, '');
+                $value = $row[$property] ?? '';
 
                 if (is_array($value)) {
                     $value = json_encode($value);
                 }
 
-                /** @var string $defaultDateFormat */
-                $defaultDateFormat = config('datatables-export.default_date_format', 'yyyy-mm-dd');
-
                 switch (true) {
                     case $this->wantsText($column):
                         $cellValue = strval($value);
@@ -180,6 +181,14 @@ public function handle()
         $writer->close();
     }
 
+    /**
+     * @return string
+     */
+    protected function getDisk(): string
+    {
+        return strval(config('datatables-export.disk', 'local'));
+    }
+
     /**
      * @param  \Yajra\DataTables\Services\DataTable  $dataTable
      * @return \Illuminate\Support\Collection<array-key, Column>
@@ -192,25 +201,24 @@ protected function getExportableColumns(DataTable $dataTable): Collection
     }
 
     /**
-     * @param  \Yajra\DataTables\Html\Column  $column
      * @return bool
      */
-    protected function wantsText(Column $column): bool
+    protected function usesLazyMethod(): bool
     {
-        if (! isset($column['exportFormat'])) {
-            return false;
-        }
-
-        return in_array($column['exportFormat'], (array) config('datatables-export.text_formats', ['@']));
+        return config('datatables-export.method', 'lazy') === 'lazy';
     }
 
     /**
      * @param  \Yajra\DataTables\Html\Column  $column
      * @return bool
      */
-    protected function wantsNumeric(Column $column): bool
+    protected function wantsText(Column $column): bool
     {
-        return Str::contains($column->exportFormat, ['0', '#']);
+        if (! isset($column['exportFormat'])) {
+            return false;
+        }
+
+        return in_array($column['exportFormat'], (array) config('datatables-export.text_formats', ['@']));
     }
 
     /**
@@ -229,6 +237,15 @@ protected function wantsDateFormat(Column $column): bool
         return in_array($column['exportFormat'], $formats);
     }
 
+    /**
+     * @param  \Yajra\DataTables\Html\Column  $column
+     * @return bool
+     */
+    protected function wantsNumeric(Column $column): bool
+    {
+        return Str::contains($column->exportFormat, ['0', '#']);
+    }
+
     /**
      * @param  int|bool|string|null  $value
      * @return bool