Merge pull request #209 from yajra/fix-phpstan

fix: failing phpstan checks

Author: yajra

src/Html/HtmlBuilder.php

@@ -89,7 +89,7 @@ public function attributes(array $attributes): string
             }
         }
 
-        return count($html) > 0 ? ' '.implode(' ', $html) : '';
+        return ! empty($html) ? ' '.implode(' ', $html) : '';
     }
 
     /**
@@ -119,7 +119,7 @@ protected function attributeElement(string $key, mixed $value): mixed
             return 'class="'.implode(' ', $value).'"';
         }
 
-        if (! is_null($value)) {
+        if (is_bool($value) || is_float($value) || is_int($value) || is_resource($value) || is_string($value)) {
             return $key.'="'.e(strval($value), false).'"';
         }
 
@@ -226,7 +226,9 @@ public function link(
             $title = $this->entities($title);
         }
 
-        return $this->toHtmlString('<a href="'.$this->entities($url).'"'.$this->attributes($attributes).'>'.$title.'</a>');
+        return $this->toHtmlString(
+            '<a href="'.$this->entities($url).'"'.$this->attributes($attributes).'>'.$title.'</a>'
+        );
     }
 
     /**
@@ -430,7 +432,7 @@ protected function listing(string $type, array $list, array $attributes = []): H
     {
         $html = '';
 
-        if (count($list) === 0) {
+        if (empty($list)) {
             return $html;
         }
 
@@ -459,8 +461,18 @@ protected function listingElement(mixed $key, string $type, mixed $value): HtmlS
         if (is_array($value)) {
             return $this->nestedListing($key, $type, $value);
         } else {
-            return '<li>'.e(strval($value), false).'</li>';
+            if (is_bool($value)
+                || is_float($value)
+                || is_int($value)
+                || is_resource($value)
+                || is_string($value)
+                || is_null($value)
+            ) {
+                return '<li>'.e(strval($value), false).'</li>';
+            }
         }
+
+        return '<li>'.$value.'</li>';
     }
 
     /**
@@ -510,7 +522,7 @@ public function dl(array $list, array $attributes = []): HtmlString
 
             $html .= "<dt>$key</dt>";
 
-            foreach ($value as $v_key => $v_value) {
+            foreach ($value as $v_value) {
                 $html .= "<dd>$v_value</dd>";
             }
         }
@@ -549,6 +561,18 @@ public function tag(string $tag, mixed $content, array $attributes = []): HtmlSt
     {
         $content = is_array($content) ? implode('', $content) : $content;
 
-        return $this->toHtmlString('<'.$tag.$this->attributes($attributes).'>'.$this->toHtmlString(strval($content)).'</'.$tag.'>');
+        if (is_bool($content)
+            || is_float($content)
+            || is_int($content)
+            || is_resource($content)
+            || is_string($content)
+            || is_null($content)
+        ) {
+            return $this->toHtmlString(
+                '<'.$tag.$this->attributes($attributes).'>'.$this->toHtmlString(strval($content)).'</'.$tag.'>'
+            );
+        }
+
+        return $this->toHtmlString('<'.$tag.$this->attributes($attributes).'>'.$content.'</'.$tag.'>');
     }
 }