fix: resolve PHPStan array key type errors #3264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix invalid array key type in CollectionDataTable::revertIndexColumn() - Fix invalid array key type in DataTableAbstract::with() - Fix instanceof and array key type issues in DataTables::make() - Fix invalid array key type in DataProcessor::process() - Fix invalid array key types in Helper::includeInArray() All fixes ensure array keys are properly typed as int|string to satisfy PHPStan's strict type checking.
- Updated multiple instances in CollectionDataTable, DataTables, DataProcessor, and Helper classes to use the Config facade for retrieving configuration values. - This change enhances consistency and aligns with best practices for configuration management in Laravel.
|
Owner
Author
|
🎉 This PR is included in version 12.6.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All fixes ensure array keys are properly typed as int|string to satisfy PHPStan's strict type checking.