Skip to content

Commit 06b1da6

Browse files
authored
Filled database name in Scheme Cache Resolve shards requests (#28247)
1 parent 0eca578 commit 06b1da6

26 files changed

+56
-26
lines changed

ydb/core/grpc_services/rpc_import_data.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ class TImportDataRPC: public TRpcRequestActor<TImportDataRPC, TEvImportDataReque
179179

180180
void ResolveKeys() {
181181
auto request = MakeHolder<TResolve>();
182-
request->DatabaseName = NKikimr::CanonizePath(GetDatabaseName());
182+
request->DatabaseName = GetDatabaseName();
183183

184184
request->ResultSet.emplace_back(std::move(KeyDesc));
185185
request->ResultSet.back().Access = NACLib::UpdateRow;

ydb/core/grpc_services/rpc_kh_describe.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,7 @@ class TKikhouseDescribeTableRPC : public TActorBootstrapped<TKikhouseDescribeTab
261261
KeyRange.Reset(new TKeyDesc(entry.TableId, range, TKeyDesc::ERowOperation::Read, KeyColumnTypes, columns));
262262

263263
TAutoPtr<NSchemeCache::TSchemeCacheRequest> request(new NSchemeCache::TSchemeCacheRequest());
264-
264+
request->DatabaseName = Request->GetDatabaseName().GetOrElse("");
265265
request->ResultSet.emplace_back(std::move(KeyRange));
266266

267267
TAutoPtr<TEvTxProxySchemeCache::TEvResolveKeySet> resolveReq(new TEvTxProxySchemeCache::TEvResolveKeySet(request));

ydb/core/grpc_services/rpc_object_storage.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ class TObjectStorageListingRequestGrpc : public TActorBootstrapped<TObjectStorag
444444

445445
void ResolveShards(const NActors::TActorContext& ctx) {
446446
TAutoPtr<NSchemeCache::TSchemeCacheRequest> request(new NSchemeCache::TSchemeCacheRequest());
447-
447+
request->DatabaseName = GrpcRequest->GetDatabaseName().GetOrElse("");
448448
request->ResultSet.emplace_back(std::move(KeyRange));
449449

450450
TAutoPtr<TEvTxProxySchemeCache::TEvResolveKeySet> resolveReq(new TEvTxProxySchemeCache::TEvResolveKeySet(request));

ydb/core/grpc_services/rpc_read_columns.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ class TReadColumnsRPC : public TActorBootstrapped<TReadColumnsRPC> {
590590
<< " fromInclusive: " << true);
591591

592592
TAutoPtr<NSchemeCache::TSchemeCacheRequest> request(new NSchemeCache::TSchemeCacheRequest());
593-
593+
request->DatabaseName = Request->GetDatabaseName().GetOrElse("");
594594
request->ResultSet.emplace_back(std::move(KeyRange));
595595

596596
TAutoPtr<TEvTxProxySchemeCache::TEvResolveKeySet> resolveReq(new TEvTxProxySchemeCache::TEvResolveKeySet(request));

ydb/core/grpc_services/rpc_read_rows.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -445,6 +445,7 @@ class TReadRowsRPC : public TActorBootstrapped<TReadRowsRPC> {
445445
auto keyRange = MakeHolder<TKeyDesc>(entry.TableId, range, TKeyDesc::ERowOperation::Read, KeyColumnTypes, columns);
446446

447447
auto request = std::make_unique<NSchemeCache::TSchemeCacheRequest>();
448+
request->DatabaseName = GetDatabase();
448449
request->ResultSet.emplace_back(std::move(keyRange));
449450
Send(MakeSchemeCacheID(), new TEvTxProxySchemeCache::TEvResolveKeySet(request.release()), 0, 0, Span.GetTraceId());
450451
}

ydb/core/kqp/compute_actor/kqp_compute_actor.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,11 +183,12 @@ IActor* CreateKqpScanComputeActor(const TActorId& executerId, ui64 txId,
183183
}
184184

185185
IActor* CreateKqpScanFetcher(const NKikimrKqp::TKqpSnapshot& snapshot, std::vector<NActors::TActorId>&& computeActors,
186-
const NKikimrTxDataShard::TKqpTransaction::TScanTaskMeta& meta, const NYql::NDq::TComputeRuntimeSettings& settings, const ui64 txId,
187-
TMaybe<ui64> lockTxId, ui32 lockNodeId, TMaybe<NKikimrDataEvents::ELockMode> lockMode, const TShardsScanningPolicy& shardsScanningPolicy,
186+
const NKikimrTxDataShard::TKqpTransaction::TScanTaskMeta& meta, const NYql::NDq::TComputeRuntimeSettings& settings,
187+
const TString& database, const ui64 txId, TMaybe<ui64> lockTxId, ui32 lockNodeId,
188+
TMaybe<NKikimrDataEvents::ELockMode> lockMode, const TShardsScanningPolicy& shardsScanningPolicy,
188189
TIntrusivePtr<TKqpCounters> counters, NWilson::TTraceId traceId, const TCPULimits& cpuLimits) {
189-
return new NScanPrivate::TKqpScanFetcherActor(snapshot, settings, std::move(computeActors), txId, lockTxId, lockNodeId, lockMode, meta,
190-
shardsScanningPolicy, counters, std::move(traceId), cpuLimits);
190+
return new NScanPrivate::TKqpScanFetcherActor(snapshot, settings, std::move(computeActors), txId, lockTxId, lockNodeId, lockMode,
191+
database, meta, shardsScanningPolicy, counters, std::move(traceId), cpuLimits);
191192
}
192193

193194
} // namespace NKikimr::NKqp

ydb/core/kqp/compute_actor/kqp_compute_actor.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ IActor* CreateKqpScanComputeActor(const TActorId& executerId, ui64 txId, NYql::N
7575

7676
IActor* CreateKqpScanFetcher(const NKikimrKqp::TKqpSnapshot& snapshot, std::vector<NActors::TActorId>&& computeActors,
7777
const NKikimrTxDataShard::TKqpTransaction::TScanTaskMeta& meta, const NYql::NDq::TComputeRuntimeSettings& settings,
78-
const ui64 txId, TMaybe<ui64> lockTxId, ui32 lockNodeId, TMaybe<NKikimrDataEvents::ELockMode> lockMode, const TShardsScanningPolicy& shardsScanningPolicy,
78+
const TString& database, const ui64 txId, TMaybe<ui64> lockTxId, ui32 lockNodeId,
79+
TMaybe<NKikimrDataEvents::ELockMode> lockMode, const TShardsScanningPolicy& shardsScanningPolicy,
7980
TIntrusivePtr<TKqpCounters> counters, NWilson::TTraceId traceId, const TCPULimits& cpuLimits);
8081

8182
NYql::NDq::IDqAsyncIoFactory::TPtr CreateKqpAsyncIoFactory(

ydb/core/kqp/compute_actor/kqp_scan_fetcher_actor.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,14 @@ constexpr TDuration PING_PERIOD = TDuration::Seconds(30);
2424

2525
TKqpScanFetcherActor::TKqpScanFetcherActor(const NKikimrKqp::TKqpSnapshot& snapshot, const TComputeRuntimeSettings& settings,
2626
std::vector<NActors::TActorId>&& computeActors, const ui64 txId, const TMaybe<ui64> lockTxId, const ui32 lockNodeId,
27-
const TMaybe<NKikimrDataEvents::ELockMode> lockMode, const NKikimrTxDataShard::TKqpTransaction_TScanTaskMeta& meta,
28-
const TShardsScanningPolicy& shardsScanningPolicy, TIntrusivePtr<TKqpCounters> counters, NWilson::TTraceId traceId,
27+
const TMaybe<NKikimrDataEvents::ELockMode> lockMode, const TString& database,
28+
const NKikimrTxDataShard::TKqpTransaction_TScanTaskMeta& meta, const TShardsScanningPolicy& shardsScanningPolicy,
29+
TIntrusivePtr<TKqpCounters> counters, NWilson::TTraceId traceId,
2930
const TCPULimits& cpuLimits)
3031
: Meta(meta)
3132
, ScanDataMeta(Meta)
3233
, RuntimeSettings(settings)
34+
, Database(database)
3335
, TxId(txId)
3436
, LockTxId(lockTxId)
3537
, LockNodeId(lockNodeId)
@@ -648,6 +650,7 @@ void TKqpScanFetcherActor::ResolveShard(TShardState& state) {
648650
<< ", attempt #" << state.ResolveAttempt);
649651

650652
auto request = MakeHolder<NSchemeCache::TSchemeCacheRequest>();
653+
request->DatabaseName = Database;
651654
request->ResultSet.emplace_back(std::move(keyDesc));
652655
Send(MakeSchemeCacheID(), new TEvTxProxySchemeCache::TEvResolveKeySet(request));
653656
}

ydb/core/kqp/compute_actor/kqp_scan_fetcher_actor.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ class TKqpScanFetcherActor: public NActors::TActorBootstrapped<TKqpScanFetcherAc
5050
NKikimrTxDataShard::TKqpTransaction::TScanTaskMeta Meta;
5151
const NMiniKQL::TScanDataMetaFull ScanDataMeta;
5252
const NYql::NDq::TComputeRuntimeSettings RuntimeSettings;
53+
const TString Database;
5354
const NYql::NDq::TTxId TxId;
5455
const TMaybe<ui64> LockTxId;
5556
const ui32 LockNodeId;
@@ -63,9 +64,9 @@ class TKqpScanFetcherActor: public NActors::TActorBootstrapped<TKqpScanFetcherAc
6364

6465
TKqpScanFetcherActor(const NKikimrKqp::TKqpSnapshot& snapshot, const NYql::NDq::TComputeRuntimeSettings& settings,
6566
std::vector<NActors::TActorId>&& computeActors, const ui64 txId, const TMaybe<ui64> lockTxId, const ui32 lockNodeId,
66-
const TMaybe<NKikimrDataEvents::ELockMode> lockMode, const NKikimrTxDataShard::TKqpTransaction_TScanTaskMeta& meta,
67-
const TShardsScanningPolicy& shardsScanningPolicy, TIntrusivePtr<TKqpCounters> counters, NWilson::TTraceId traceId,
68-
const TCPULimits& cpuLimits);
67+
const TMaybe<NKikimrDataEvents::ELockMode> lockMode, const TString& database,
68+
const NKikimrTxDataShard::TKqpTransaction_TScanTaskMeta& meta, const TShardsScanningPolicy& shardsScanningPolicy,
69+
TIntrusivePtr<TKqpCounters> counters, NWilson::TTraceId traceId, const TCPULimits& cpuLimits);
6970

7071
static TVector<TSerializedTableRange> BuildSerializedTableRanges(
7172
const NKikimrTxDataShard::TKqpTransaction::TScanTaskMeta::TReadOpMeta& readData);

ydb/core/kqp/executer_actor/kqp_partitioned_executer.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -426,6 +426,7 @@ class TKqpPartitionedExecuter : public TActorBootstrapped<TKqpPartitionedExecute
426426
auto keyRange = MakeHolder<TKeyDesc>(TableId, range, OperationType, KeyColumnTypes, TVector<TKeyDesc::TColumnOp>{});
427427

428428
TAutoPtr<NSchemeCache::TSchemeCacheRequest> request(new NSchemeCache::TSchemeCacheRequest());
429+
request->DatabaseName = Database;
429430
request->ResultSet.emplace_back(std::move(keyRange));
430431

431432
TAutoPtr<TEvTxProxySchemeCache::TEvResolveKeySet> resolveReq(new TEvTxProxySchemeCache::TEvResolveKeySet(request));

0 commit comments

Comments
 (0)