Fix crashing on decompression error (#28140) (#28209)

FloatingCrowbar · web-flow · commit 8f6e512ca3ce · 2025-11-05T13:10:31.000+03:00
diff --git a/ydb/core/viewer/viewer_topic_data.cpp b/ydb/core/viewer/viewer_topic_data.cpp
@@ -201,7 +201,11 @@ void TTopicData::FillProtoResponse(ui64 maxTotalSize) {
             if (codec == nullptr) {
                 return ReplyAndPassAway(GetHTTPINTERNALERROR("text/plain", "Message decompression failed"));
             }
-            setData(*messageProto, std::move(codec->Decompress(dataChunk.GetData())));
+            try {
+                setData(*messageProto, std::move(codec->Decompress(dataChunk.GetData())));
+            } catch (const std::exception& e) {
+                setData(*messageProto, ">>> Message decompression failed <<<");
+            }
         } else {
             setData(*messageProto, std::move(*dataChunk.MutableData()));
         }

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,11 @@ void TTopicData::FillProtoResponse(ui64 maxTotalSize) {`
`201`	`201`	`if (codec == nullptr) {`
`202`	`202`	`return ReplyAndPassAway(GetHTTPINTERNALERROR("text/plain", "Message decompression failed"));`
`203`	`203`	`}`
`204`		`- setData(*messageProto, std::move(codec->Decompress(dataChunk.GetData())));`
	`204`	`+ try {`
	`205`	`+ setData(*messageProto, std::move(codec->Decompress(dataChunk.GetData())));`
	`206`	`+ } catch (const std::exception& e) {`
	`207`	`+ setData(*messageProto, ">>> Message decompression failed <<<");`
	`208`	`+ }`
`205`	`209`	`} else {`
`206`	`210`	`setData(messageProto, std::move(dataChunk.MutableData()));`
`207`	`211`	`}`