#17191: improved ensureScheme tests readability

ggh2e3 · ggh2e3 · commit 005a9c72652b · 2023-12-03T16:21:45.000+01:00
diff --git a/tests/framework/helpers/BaseUrlTest.php b/tests/framework/helpers/BaseUrlTest.php
@@ -23,9 +23,9 @@ public function testIsRelativeWillReturnFalse($url)
     }
 
     /** @dataProvider ensureSchemeUrlProvider */
-    public function testEnsureScheme()
+    public function testEnsureScheme($url, $scheme, $expected)
     {
-
+        $this->assertEquals($expected, BaseUrl::ensureScheme($url, $scheme));
     }
 
     public function ensureSchemeUrlProvider()

Original file line number	Diff line number	Diff line change
`@@ -23,9 +23,9 @@ public function testIsRelativeWillReturnFalse($url)`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`/** @dataProvider ensureSchemeUrlProvider */`
`26`		`- public function testEnsureScheme()`
	`26`	`+ public function testEnsureScheme($url, $scheme, $expected)`
`27`	`27`	`{`
`28`		`-`
	`28`	`+ $this->assertEquals($expected, BaseUrl::ensureScheme($url, $scheme));`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`public function ensureSchemeUrlProvider()`