-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
CUBRID (remove o move to extesion) database support from Yii2 core. #20544
Replies: 4 comments · 11 replies
-
|
I'm in favor of removing it. People who use it can stay on previous version or migrate to anotjer supported db. I doubt if such users exists though. I would love to be proven wrong! |
Beta Was this translation helpful? Give feedback.
All reactions
-
|
Technically this is a huge BC break. I don't think that this should be done in a minor release. |
Beta Was this translation helpful? Give feedback.
All reactions
-
Because we believe Yii should be maintained and get new language features for quiet sometime. This specific code will no longer be updated with new version of Cubrid, is untested and will just be a bad taste to a framework. At worst case, my opinion is it should go to an extension and slowly die there. And if someone deems important can make PR |
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 2
-
Beta Was this translation helpful? Give feedback.
All reactions
-
|
If it ever worked, they must have a frozen version, because it’s probably been broken for a long time, btw you need to install and compile the PDO driver, since PECL is abandoned, and you’ll have to do some magic to get it to compile. |
Beta Was this translation helpful? Give feedback.
All reactions
-
|
Then maybe it's worth finding a working version (if one even exists) and putting it into an extension? |
Beta Was this translation helpful? Give feedback.
All reactions
-
|
That's dragging technical debt into a repository that almost no one will use. I honestly doubt it will work in PHP 8.0, and PHP 7.4 has already reached the end of its useful life. |
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 1
-
|
I support its removal. But maybe it should be deprecated first and removed after a few versions? |
Beta Was this translation helpful? Give feedback.
All reactions
-
|
@rob006 ignoring test might bring some instability if anything changes that ends up breaking something. It will be hard to catch it without tests. Your point on composer update breaking are thoughtful, though I think adding upgrade comments that show up on upgrade can mitigate that. I think we just need better plan to remove it as I don't see anywhere in near future the PHP version will be bumped to 8.0. I might be wrong though |
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 1
-
That is a valid concern, but removing the feature completely is event worse: instead of risks of bugs you are guaranteed a break in any project that may still use Cubrid. That is not an improvement. |
Beta Was this translation helpful? Give feedback.

Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
This proposes (removing o move) CUBRID database support from Yii2 core framework in version
2.0.54, along with the recent PHP7.4requirement increase.@rob006 @samdark @bizley @mtangoo @max-s-lab @schmunk42 @SilverFire @xicond
Beta Was this translation helpful? Give feedback.
All reactions