Skip to content

Conversation

@candeodevelopment
Copy link
Contributor

Proposed change

Adds support for Candeo SR5BR 5-button remote with rotating dial.

Additional information

@TheJulianJES we added a few new consts to const.py to support this device:

BUTTON_CENTRE = "button_centre"
STOPPED_ROTATING_WITH_DIRECTION = "rotary_knob_stopped_rotating_with_direction"

Would you be able to add these translation strings to HA's ZHA integration when you get a chance please?

"trigger_type": {
    "rotary_knob_stopped_rotating_with_direction": "Rotary knob stopped rotating \"{subtype}\"",
}

"trigger_subtype": {
    "button_centre": "Centre Button",
}

If possible please could you also give us some pointers on which (if any) unit tests would be needed for this PR?

Device diagnostics

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 92.85714% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.24%. Comparing base (928268c) to head (f08de42).
⚠️ Report is 8 commits behind head on dev.

Files with missing lines Patch % Lines
...irks/candeo/scene_switch_remote_5_button_rotary.py 92.68% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4470   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         369      370    +1     
  Lines       12094    12178   +84     
=======================================
+ Hits        11156    11234   +78     
- Misses        938      944    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pre-commit-ci bot and others added 5 commits November 7, 2025 16:31
Updated some code while we are working on unit tests
Added unit tests for the Candeo SR5BR 5-button remote with rotating dial
@candeodevelopment
Copy link
Contributor Author

We added a bunch of unit tests that hopefully fully test all device combinations!

Please let us know if anything further is required.

@TheJulianJES TheJulianJES added the manufacturer This request was made by the device's manufacturer label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manufacturer This request was made by the device's manufacturer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants