-
Notifications
You must be signed in to change notification settings - Fork 926
Add Candeo SR5BR 5-button remote with rotating dial #4470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Adds support for Candeo SR5BR 5-button remote with rotating dial
Implement CI code improvement suggestions
Add missing import path
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4470 +/- ##
=======================================
Coverage 92.24% 92.24%
=======================================
Files 369 370 +1
Lines 12094 12178 +84
=======================================
+ Hits 11156 11234 +78
- Misses 938 944 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Updated some code while we are working on unit tests
Added unit tests for the Candeo SR5BR 5-button remote with rotating dial
|
We added a bunch of unit tests that hopefully fully test all device combinations! Please let us know if anything further is required. |
Proposed change
Adds support for Candeo SR5BR 5-button remote with rotating dial.
Additional information
@TheJulianJES we added a few new consts to const.py to support this device:
Would you be able to add these translation strings to HA's ZHA integration when you get a chance please?
If possible please could you also give us some pointers on which (if any) unit tests would be needed for this PR?
Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black